Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix extending selectors across multiple modules. #1298

Merged
merged 2 commits into from Apr 28, 2021
Merged

Fix extending selectors across multiple modules. #1298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c7e7ee
Fix extending selectors across multiple modules.
Awjin Apr 27, 2021
dec3ef8
Code review.
Awjin Apr 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
@@ -1,3 +1,9 @@
## 1.32.12

* Fix a bug that disallowed more than one module from extending the same
selector from a module if that selector itself extended a selector from
another upstream module.

## 1.32.11

* Fix a bug where bogus indented syntax errors were reported for lines that
Expand Down
2 changes: 1 addition & 1 deletion lib/src/extend/extension_store.dart
View file
Open in desktop
Expand Up @@ -328,7 +328,7 @@ class ExtensionStore {
}

var containsExtension = selectors.first == extension.extender.selector;
var first = false;
var first = true;
for (var complex in selectors) {
// If the output contains the original complex selector, there's no
// need to recreate it.
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
@@ -1,5 +1,5 @@
name: sass
version: 1.32.11
version: 1.32.12
description: A Sass implementation in Dart.
author: Sass Team
homepage: https://github.com/sass/dart-sass
Expand Down