Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable strict null checks #1283

Merged
merged 19 commits into from Apr 15, 2021
Merged

Enable strict null checks #1283

merged 19 commits into from Apr 15, 2021

Commits on Apr 13, 2021

  1. Update dependencies to null-safe versions

    This also replaces package_resolver with package_config, since
    package_resolver is archived and is incompatible with null-safe Dart
    packages.
    jathak authored and nex3 committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    247cb3d View commit details
    Browse the repository at this point in the history
  2. Fix hints and lints

    nex3 committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    3fa2b1d View commit details
    Browse the repository at this point in the history
  3. Split IfClause into ElseClause

    This allows us to be statically explicit about when the expression
    does or doesn't exist.
    nex3 committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    5d0ad69 View commit details
    Browse the repository at this point in the history
  4. Refactor how style rules interact with at-root

    This is more friendly to null-safe code, since we no longer rely on
    `_inStyleRule` implying that `_styleRule != null`.
    nex3 committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    ca3c6f5 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2021

  1. Split Declaration's constructor into two

    This doesn't explicitly help null-safety, but it makes the
    relationship between `Declaration.value` and `Declaration.children`
    more obvious.
    nex3 committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    21e7ec1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    984e76e View commit details
    Browse the repository at this point in the history
  3. Make the first parameter to ImportCache() named, not mandatory

    It was always valid to pass in `null`, this just makes it more clear.
    nex3 committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    8fdb281 View commit details
    Browse the repository at this point in the history
  4. Prepare for null-safety migration

    jathak authored and nex3 committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    dfbdae0 View commit details
    Browse the repository at this point in the history
  5. Automated null-safety migration

    nex3 committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    81d952d View commit details
    Browse the repository at this point in the history
  6. Fix automated migrator errors

    This gets the project analyzer-clean, but the tests are still failing.
    nex3 committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    e85d9a7 View commit details
    Browse the repository at this point in the history
  7. Rename Extender to ExtensionStore

    "Extender" is also commonly used to refer to the parent selector of an
    `@extend` rule, so this helps disambiguate.
    nex3 committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    8fd3c1b View commit details
    Browse the repository at this point in the history
  8. Split out an Extender class from Extension

    This gets rid of the weird subset of "one-off" extensions which didn't
    have target information available. Now instead, each method explicitly
    declares whether it takes/returns extensions (which do have target
    info) or extenders (which do not).
    nex3 committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    3ead2e2 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    de013bf View commit details
    Browse the repository at this point in the history
  10. Fix bogus null assertions

    nex3 committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    654744f View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    102d3ce View commit details
    Browse the repository at this point in the history
  12. Fix broken tests

    Awjin authored and nex3 committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    af0f25c View commit details
    Browse the repository at this point in the history
  13. Fix broken specs

    nex3 committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    5535458 View commit details
    Browse the repository at this point in the history
  14. Update the pubspec

    nex3 committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    59b9dac View commit details
    Browse the repository at this point in the history
  15. Use ?[] instead of .andGet()

    nex3 committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    c2e02a5 View commit details
    Browse the repository at this point in the history