Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw a proper error when the same built-in module is @used twice #1070

Merged
merged 2 commits into from
Sep 4, 2020
Merged

Throw a proper error when the same built-in module is @used twice #1070

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
215eb82
Throw a proper error when the same built-in module is @used twice
nex3 Sep 3, 2020
e8057f9
Merge branch 'master' into conflicting-built-in-namespace
nex3 Sep 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

* Improve some error messages for edge-case parse failures.

* Throw a proper error when the same built-in module is `@use`d twice.

## 1.26.10

* Fixes a bug where two adjacent combinators could cause an error.
Expand Down
2 changes: 1 addition & 1 deletion lib/src/visitor/async_evaluate.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,7 +549,7 @@ class _EvaluateVisitor
nodeWithSpan.span);
}

callback(builtInModule);
_addExceptionSpan(nodeWithSpan, () => callback(builtInModule));
return;
}

Expand Down
4 changes: 2 additions & 2 deletions lib/src/visitor/evaluate.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
// DO NOT EDIT. This file was generated from async_evaluate.dart.
// See tool/grind/synchronize.dart for details.
//
// Checksum: 7f6c1eeddc48b08b4ff3f95c3af19cdf8afdfb1b
// Checksum: f6fe6645ccec58216ef623851bd2594de291a360
//
// ignore_for_file: unused_import

Expand Down Expand Up @@ -552,7 +552,7 @@ class _EvaluateVisitor
nodeWithSpan.span);
}

callback(builtInModule);
_addExceptionSpan(nodeWithSpan, () => callback(builtInModule));
return;
}

Expand Down