New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add partial support for Media Queries Level 4 #1749
Conversation
"If conditions is longer than one element, conjunction may not be " | ||
"null."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: would adding single-quotes around conditions
and conjunction
make it more readable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not the typical style for ArgumentErrors, I think, and hewing to a common style is probably more valuable overall.
type = identifier1; | ||
var identifier2 = identifier(); | ||
|
||
if (equalsIgnoreCase(identifier2, "and")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, it took me a while to review because I was confused about this part, I was reading the syntax for <media-query>
and I didn't realize it had two lines 😅 (the second showing [ not | only ]? <media-type> [ and <media-condition-without-or> ]?
)
I didn't realize one could have and
like that but not or
:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it has to balance remaining compatible with the legacy syntax even in places where it's confusing with supporting the new syntax.
Also include some code review changes that were meant for #1749
Also include some code review changes that were meant for #1749
|
||
int get hashCode => modifier.hashCode ^ type.hashCode ^ listHash(features); | ||
int get hashCode => modifier.hashCode ^ type.hashCode ^ listHash(conditions); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conjunction
should be taken into account by equality checks.
See sass/sass#2538
See #1728
See sass/sass-spec#1807