Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support full media query conditions #2538

Closed
8 tasks done
nex3 opened this issue Jul 12, 2018 · 5 comments
Closed
8 tasks done

Support full media query conditions #2538

nex3 opened this issue Jul 12, 2018 · 5 comments
Labels
CSS compatibility Support the CSS spec

Comments

@nex3
Copy link
Contributor

nex3 commented Jul 12, 2018

Deprecation

Final


The Media Queries Level 4 spec defines syntax for full boolean algebra among media features. At time of writing, I believe no browsers support this syntax, but once one does Sass should add support as well.

In addition to parsing additional forms, this will affect Sass's media query merging logic. For example, merging not print and (min-width: 600px) should produce not print and not (min-width: 600px) rather than failing entirely.

@nex3 nex3 added CSS compatibility Support the CSS spec awaiting browser support Blocked on at least one browser implementing something labels Jul 12, 2018
@stof
Copy link
Contributor

stof commented Mar 17, 2022

For reference, this is supported in Firefox 63+.
And looking at the Chromium issue tracker, they have some in-progress work done (probably related to their implementation of container queries, as they rely on that range syntax too)

@stof
Copy link
Contributor

stof commented Jun 17, 2022

Those are announced to be shipping in Chrome 104, which should make the awaited browser support being there as Firefox already shipped them.
https://caniuse.com/mdn-css_at-rules_media_range_syntax

@nex3
Copy link
Contributor Author

nex3 commented Jun 22, 2022

I have a PR out for a proposal: #3344

@nex3
Copy link
Contributor Author

nex3 commented Jun 23, 2022

The proposal has landed. Since it's relatively straightforward and unlikely to change, I'll give it two weeks for public comment.

nex3 added a commit to sass/dart-sass that referenced this issue Jul 20, 2022
nex3 added a commit to sass/dart-sass that referenced this issue Jul 20, 2022
nex3 added a commit to sass/dart-sass that referenced this issue Jul 22, 2022
@nex3 nex3 added the blocked Waiting on another issue to be fixed label Jul 22, 2022
@nex3 nex3 removed their assignment Jul 22, 2022
@nex3 nex3 removed the blocked Waiting on another issue to be fixed label Jul 22, 2022
@nex3
Copy link
Contributor Author

nex3 commented Jul 22, 2022

The initial deprecation phase has landed. We'll wait at least three months to give users a chance to migrate away from the deprecated syntax, then land full support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS compatibility Support the CSS spec
Projects
None yet
Development

No branches or pull requests

2 participants