Enable strict null checks #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also replaces package_resolver with package_config, since package_resolver is archived and is incompatible with null-safe Dart packages.
This allows us to be statically explicit about when the expression does or doesn't exist.
This is more friendly to null-safe code, since we no longer rely on `_inStyleRule` implying that `_styleRule != null`.
nex3
force-pushed
the
nnbd
branch
7 times, most recently
from
2a3a87f
to
481c96b
Compare
This doesn't explicitly help null-safety, but it makes the relationship between `Declaration.value` and `Declaration.children` more obvious.
It was always valid to pass in `null`, this just makes it more clear.
This gets the project analyzer-clean, but the tests are still failing.
"Extender" is also commonly used to refer to the parent selector of an `@extend` rule, so this helps disambiguate.
This gets rid of the weird subset of "one-off" extensions which didn't have target information available. Now instead, each method explicitly declares whether it takes/returns extensions (which do have target info) or extenders (which do not).
jathak
approved these changes
Apr 15, 2021
lib/src/visitor/async_evaluate.dart
Outdated
| @@ -2487,8 +2494,8 @@ class _EvaluateVisitor | |||
| nodeWithSpan, () => arguments.verify(positional, MapKeySet(named))); | |||
|
|
|||
| Future<Value> visitSelectorExpression(SelectorExpression node) async { | |||
| if (_styleRule == null) return sassNull; | |||
| return _styleRule.originalSelector.asSassList; | |||
| if (_styleRuleIgnoringAtRoot == null) return sassNull; | |||
There was a problem hiding this comment.
What determines when _styleRuleIgnoringAtRoot should be used instead of _styleRule?
There was a problem hiding this comment.
The spec, mostly—in this case, & as an expression always ignores @at-root so you can interpolate it into selectors. Separating out these variables not only makes it more explicit which references respect @at-root and which don't, it also removes the implicit constraint that _inStyleRule means that _styleRule != null. Instead, we just check _styleRule == null, which is more visible to the type system.
jathak
reviewed
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See sass/sass-spec#1632