Allow the null safety release of stream_transform #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nex3 ? |
|
|
kevmoo
reviewed
Feb 8, 2021
| @@ -25,7 +25,7 @@ dependencies: | |||
| source_maps: "^0.10.5" | |||
| source_span: "^1.6.0" | |||
| stack_trace: ">=0.9.0 <2.0.0" | |||
| stream_transform: ">=0.0.20 <2.0.0" | |||
| stream_transform: ">=0.0.20 <3.0.0" | |||
There was a problem hiding this comment.
We just published the stable release of stream_transform. It'll be picked up by a fresh pub get.
@nex3 – if you restart the tests here, we can confirm it's picked up on the Dart dev builds to ensure nothing is broken.
There was a problem hiding this comment.
I rebased the branch on top of master so the tests got restared as well. The new stable stream_transform was picked and it seems that everything works fine.
lukaszkolodziejczyk
force-pushed
the
patch-1
branch
from
9f21b8e
to
1fba2c0
Compare
lukaszkolodziejczyk
force-pushed
the
patch-1
branch
from
1fba2c0
to
1c5a3a5
Compare
|
LGTM, thanks. |
Awjin
referenced
this pull request
Feb 10, 2021
This advances the scanner to the next line even if the !default identifier is not followed by a comma.
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.