Skip to content

Commit

Permalink
Let last !default value of @forward...with be commaless. (#1226)
Browse files Browse the repository at this point in the history
This advances the scanner to the next line even if the !default
identifier is not followed by a comma.
  • Loading branch information
Awjin Ahn committed Feb 4, 2021
1 parent 8afc238 commit 4ea9fff
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 2 deletions.
7 changes: 6 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 1.32.8

This comment has been minimized.

Copy link
@stof

stof Feb 9, 2021

Contributor

this change is wrong, as 1.32.7 is not released yet

This comment has been minimized.

Copy link
@Awjin

Awjin Feb 10, 2021

Contributor

fixed in #1223


* Allow `@forward...with` to take arguments that have a `!default` flag without
a trailing comma.

## 1.32.7

* Improve the performance of unitless and single-unit numbers.
Expand Down Expand Up @@ -63,7 +68,7 @@

* Properly mark some warnings emitted by `sass:color` functions as deprecation
warnings.

### Dart API

* Rename `SassNumber.valueInUnits()` to `SassNumber.coerceValue()`. The old name
Expand Down
1 change: 1 addition & 0 deletions lib/src/parse/stylesheet.dart
Original file line number Diff line number Diff line change
Expand Up @@ -1432,6 +1432,7 @@ relase. For details, see http://bit.ly/moz-document.
var flag = identifier();
if (flag == 'default') {
guarded = true;
whitespace();
} else {
error("Invalid flag name.", scanner.spanFrom(flagStart));
}
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: sass
version: 1.32.7
version: 1.32.8-dev
description: A Sass implementation in Dart.
author: Sass Team
homepage: https://github.com/sass/dart-sass
Expand Down

0 comments on commit 4ea9fff

Please sign in to comment.