Produce a better error for positional arguments after named (#1087)

Closes #1086
sass · Sep 18, 2020 · f843f96 · f843f96
1 parent 6ec78f9
commit f843f96
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,6 +11,9 @@
 
 * Don't crash when writing `Infinity` in JS mode.
 
+* Produce a better error message for positional arguments following named
+  arguments.
+
 ## 1.26.10
 
 * Fixes a bug where two adjacent combinators could cause an error.

diff --git a/lib/src/parse/stylesheet.dart b/lib/src/parse/stylesheet.dart
@@ -1581,7 +1581,9 @@ relase. For details, see http://bit.ly/moz-document.
           break;
         }
       } else if (named.isNotEmpty) {
-        scanner.expect("...");
+        error(
+            "Positional arguments must come before keyword arguments.",
+            expression.span);
       } else {
         positional.add(expression);
       }

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,5 +1,5 @@
 name: sass
-version: 1.26.11-dev
+version: 1.26.11
 description: A Sass implementation in Dart.
 author: Sass Team
 homepage: https://github.com/sass/dart-sass