Skip to content

Commit

Permalink
Drop support for Node 8.x
Browse files Browse the repository at this point in the history
url.pathToFileURL, which wasn't supported until Node 10.x, is now used
in node_preamble.
  • Loading branch information
nex3 committed Jul 22, 2019
1 parent b1707f6 commit d0f471c
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
3 changes: 0 additions & 3 deletions .travis.yml
Expand Up @@ -77,9 +77,6 @@ jobs:
node_js: stable
install: pub run grinder before-test
script: tool/travis/task/node_tests.sh
- <<: *node-tests
name: Node tests | Dart stable | Node Carbon
node_js: lts/carbon
- <<: *node-tests
name: Node tests | Dart stable | Node Dubnium
node_js: lts/dubnium
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
Expand Up @@ -5,6 +5,8 @@
* Don't crash when running in a directory whose name contains URL-sensitive
characters.

* Drop support for Node Carbon (8.x), which doesn't support `url.pathToFileURL`.

## 1.22.7

* Restrict the supported versions of the Dart SDK to `^2.4.0`.
Expand Down
2 changes: 1 addition & 1 deletion package/package.json
Expand Up @@ -14,7 +14,7 @@
"url": "https://github.com/nex3"
},
"engines": {
"node": ">=0.11.8"
"node": ">=10.0.0"
},
"dependencies": {
"chokidar": ">=2.0.0 <4.0.0"
Expand Down

2 comments on commit d0f471c

@Turbo87
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nex3 this looks like a breaking change to me. any reason why this was released in a patch version release instead of a major version?

@nex3
Copy link
Contributor Author

@nex3 nex3 commented on d0f471c Sep 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #780

Please sign in to comment.