Set LegacyResult.map to undefined rather than null (#1592)

sass · Jan 10, 2022 · 720c358 · 720c358
1 parent 54fd309
commit 720c358
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,10 @@
+## 1.47.1
+
+### JS API
+
+* **Potentially breaking bug fix:** Match the specification of the new JS API by
+  setting `LegacyResult.map` to `undefined` rather than `null`.
+
 ## 1.47.0
 
 ### JS API

diff --git a/lib/src/node/legacy.dart b/lib/src/node/legacy.dart
@@ -357,7 +357,10 @@ RenderResult _newRenderResult(
   var end = DateTime.now();
 
   var css = result.css;
-  Uint8List? sourceMapBytes;
+  // TODO(nweiz): Get rid of this cast once pulyaevskiy/node-interop#109 is
+  // released.
+  // ignore: prefer_void_to_null
+  Uint8List? sourceMapBytes = undefined as Null;
   if (_enableSourceMaps(options)) {
     var sourceMapOption = options.sourceMap;
     var sourceMapPath =

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,5 +1,5 @@
 name: sass
-version: 1.47.0
+version: 1.47.1-dev
 description: A Sass implementation in Dart.
 homepage: https://github.com/sass/dart-sass