Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rename tls flag const #69

Merged
merged 1 commit into from Sep 2, 2022
Merged

refactor: rename tls flag const #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
24 changes: 12 additions & 12 deletions pkg/analyzer/analyzer.go
View file
Open in desktop
Expand Up @@ -14,16 +14,16 @@ import (
)

const (
TimeWeekdayFlag = "time-weekday"
TimeMonthFlag = "time-month"
TimeLayoutFlag = "time-layout"
CryptoHashFlag = "crypto-hash"
HTTPMethodFlag = "http-method"
HTTPStatusCodeFlag = "http-status-code"
RPCDefaultPathFlag = "rpc-default-path"
OSDevNullFlag = "os-dev-null"
SQLIsolationLevelFlag = "sql-isolation-level"
TLSSignatureScheme = "tls-signature-scheme"
TimeWeekdayFlag = "time-weekday"
TimeMonthFlag = "time-month"
TimeLayoutFlag = "time-layout"
CryptoHashFlag = "crypto-hash"
HTTPMethodFlag = "http-method"
HTTPStatusCodeFlag = "http-status-code"
RPCDefaultPathFlag = "rpc-default-path"
OSDevNullFlag = "os-dev-null"
SQLIsolationLevelFlag = "sql-isolation-level"
TLSSignatureSchemeFlag = "tls-signature-scheme"
)

// New returns new usestdlibvars analyzer.
Expand All @@ -48,7 +48,7 @@ func flags() flag.FlagSet {
flags.Bool(RPCDefaultPathFlag, false, "suggest the use of rpc.DefaultXXPath")
flags.Bool(OSDevNullFlag, false, "suggest the use of os.DevNull")
flags.Bool(SQLIsolationLevelFlag, false, "suggest the use of sql.LevelXX.String()")
flags.Bool(TLSSignatureScheme, false, "suggest the use of tls.SignatureScheme.String()")
flags.Bool(TLSSignatureSchemeFlag, false, "suggest the use of tls.SignatureScheme.String()")
return *flags
}

Expand Down Expand Up @@ -107,7 +107,7 @@ func run(pass *analysis.Pass) (interface{}, error) {
checkSQLIsolationLevel(pass, n)
}

if lookupFlag(pass, TLSSignatureScheme) {
if lookupFlag(pass, TLSSignatureSchemeFlag) {
checkTLSSignatureScheme(pass, n)
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/analyzer/analyzer_test.go
View file
Open in desktop
Expand Up @@ -28,7 +28,7 @@ func TestUseStdlibVars(t *testing.T) {
mustNil(t, a.Flags.Set(analyzer.RPCDefaultPathFlag, "true"))
mustNil(t, a.Flags.Set(analyzer.OSDevNullFlag, "true"))
mustNil(t, a.Flags.Set(analyzer.SQLIsolationLevelFlag, "true"))
mustNil(t, a.Flags.Set(analyzer.TLSSignatureScheme, "true"))
mustNil(t, a.Flags.Set(analyzer.TLSSignatureSchemeFlag, "true"))

analysistest.Run(t, analysistest.TestData(), a, pkgs...)
}
Expand Down