Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use strings.Builder instead of strings.Trim #56

Merged
merged 1 commit into from Aug 26, 2022
Merged

feat: use strings.Builder instead of strings.Trim #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 10 additions & 1 deletion pkg/analyzer/analyzer.go
View file
Open in desktop
Expand Up @@ -416,7 +416,16 @@ func getBasicLitFromElts(elts []ast.Expr, key string) *ast.BasicLit {

// getBasicLitValue returns BasicLit value as string without quotes
func getBasicLitValue(basicLit *ast.BasicLit) string {
return strings.Trim(basicLit.Value, "\"")
var val strings.Builder
for i := range basicLit.Value {
switch basicLit.Value[i] {
case '\\', '"':
continue
default:
val.WriteByte(basicLit.Value[i])
}
}
return val.String()
}

func report(pass *analysis.Pass, pos token.Pos, currentVal, newVal string) {
Expand Down