Skip to content

Commit

Permalink
Refactor test cases (#77)
Browse files Browse the repository at this point in the history 
* Change format in status code test cases

* Change format in http method test cases

* Change format in common test cases
  • Loading branch information
@sashamelentyev
sashamelentyev committed Sep 19, 2022
1 parent 4fb405c commit a3c2328
Show file tree
Hide file tree
Showing 16 changed files with 2,114 additions and 9,258 deletions.
6 changes: 6 additions & 0 deletions pkg/analyzer/internal/template/test-httpmethod.go.tmpl
View file
Expand Up @@ -31,6 +31,12 @@ var (
{{- end }}
)

var (
{{- range $key, $value := .Mapping }}
_ = http.Request{Method: "{{ $key }}"} // want `"{{ quoteMeta $key }}" can be replaced by {{ quoteMeta $value }}`
{{- end }}
)

var (
{{- range $key, $value := .Mapping }}
_ = &http.Request{Method: "{{ $key }}"} // want `"{{ quoteMeta $key }}" can be replaced by {{ quoteMeta $value }}`
Expand Down
161 changes: 75 additions & 86 deletions pkg/analyzer/internal/template/test-httpstatuscode.go.tmpl
View file
Expand Up @@ -18,190 +18,179 @@ const (
_ = {{ $key }}
{{- end }}
)
{{ range $key, $value := .Mapping }}

func _() {
var w http.ResponseWriter
{{- range $key, $value := .Mapping }}
w.WriteHeader({{ $key }}) // want `"{{ quoteMeta $key }}" can be replaced by {{ quoteMeta $value }}`
{{- end }}
}
{{ end -}}

{{ range $key, $value := .Mapping }}
func _() {
var w http.ResponseWriter
{{- range $key, $value := .Mapping }}
w.WriteHeader({{ $value }})
{{- end }}
}
{{ end -}}

{{ range $key, $value := .Mapping }}
func _() {
_ = &http.Response{
StatusCode: {{ $key }}, // want `"{{ quoteMeta $key }}" can be replaced by {{ quoteMeta $value }}`
}
}
{{ end -}}
var (
{{- range $key, $value := .Mapping }}
_ = http.Response{StatusCode: {{ $key }}} // want `"{{ quoteMeta $key }}" can be replaced by {{ quoteMeta $value }}`
{{- end }}
)

{{ range $key, $value := .Mapping }}
func _() {
_ = &http.Response{
StatusCode: {{ $value }},
}
}
{{ end -}}
var (
{{- range $key, $value := .Mapping }}
_ = http.Response{StatusCode: {{ $value }}}
{{- end }}
)

{{ range $key, $value := .Mapping }}
func _() {
_ = http.Response{
StatusCode: {{ $key }}, // want `"{{ quoteMeta $key }}" can be replaced by {{ quoteMeta $value }}`
}
}
{{ end -}}
var (
{{- range $key, $value := .Mapping }}
_ = &http.Response{StatusCode: {{ $key }}} // want `"{{ quoteMeta $key }}" can be replaced by {{ quoteMeta $value }}`
{{- end }}
)

{{ range $key, $value := .Mapping }}
func _() {
_ = http.Response{
StatusCode: {{ $value }},
}
}
{{ end -}}
var (
{{- range $key, $value := .Mapping }}
_ = &http.Response{StatusCode: {{ $value }}}
{{- end }}
)

{{ range $key, $value := .Mapping }}
func _() error {
resp, err := http.DefaultClient.Do(&http.Request{})
if err != nil {
return err
}
defer func() { _ = resp.Body.Close() }()
{{- range $key, $value := .Mapping }}
if resp.StatusCode == {{ $key }} { // want `"{{ quoteMeta $key }}" can be replaced by {{ quoteMeta $value }}`
return nil
} else if resp.StatusCode == {{ $key }} { // want `"{{ quoteMeta $key }}" can be replaced by {{ quoteMeta $value }}`
return nil
}
{{- end }}
return nil
}
{{ end -}}

{{ range $key, $value := .Mapping }}
func _() error {
resp, err := http.DefaultClient.Do(&http.Request{})
if err != nil {
return err
}
defer func() { _ = resp.Body.Close() }()
{{- range $key, $value := .Mapping }}
if resp.StatusCode == {{ $value }} {
return nil
} else if resp.StatusCode == {{ $value }} {
return nil
}
{{- end }}
return nil
}
{{ end -}}

{{ range $key, $value := .Mapping }}
func _() {
var w http.ResponseWriter
{{- range $key, $value := .Mapping }}
http.Error(w, "", {{ $key }}) // want `"{{ quoteMeta $key }}" can be replaced by {{ quoteMeta $value }}`
{{- end }}
}
{{ end -}}

{{ range $key, $value := .Mapping }}
func _() {
var w http.ResponseWriter
{{- range $key, $value := .Mapping }}
http.Error(w, "", {{ $value }})
{{- end }}
}
{{ end -}}

{{ range $key, $value := .Mapping }}
func _() {
http.StatusText({{ $key }}) // want `"{{ quoteMeta $key }}" can be replaced by {{ quoteMeta $value }}`
}
{{ end -}}
var (
{{- range $key, $value := .Mapping }}
_ = http.StatusText({{ $key }}) // want `"{{ quoteMeta $key }}" can be replaced by {{ quoteMeta $value }}`
{{- end }}
)

{{ range $key, $value := .Mapping }}
func _() {
http.StatusText({{ $value }})
}
{{ end -}}
var (
{{- range $key, $value := .Mapping }}
_ = http.StatusText({{ $value }})
{{- end }}
)

{{ range $key, $value := .Mapping }}
func _() {
var w http.ResponseWriter
var r *http.Request
{{- range $key, $value := .Mapping }}
http.Redirect(w, r, "", {{ $key }}) // want `"{{ quoteMeta $key }}" can be replaced by {{ quoteMeta $value }}`
{{- end }}
}
{{ end -}}

{{ range $key, $value := .Mapping }}
func _() {
var w http.ResponseWriter
var r *http.Request
{{- range $key, $value := .Mapping }}
http.Redirect(w, r, "", {{ $value }})
{{- end }}
}
{{ end -}}

{{ range $key, $value := .Mapping }}
func _() {
http.RedirectHandler("", {{ $key }}) // want `"{{ quoteMeta $key }}" can be replaced by {{ quoteMeta $value }}`
}
{{ end -}}
var (
{{- range $key, $value := .Mapping }}
_ = http.RedirectHandler("", {{ $key }}) // want `"{{ quoteMeta $key }}" can be replaced by {{ quoteMeta $value }}`
{{- end }}
)

{{ range $key, $value := .Mapping }}
func _() {
http.RedirectHandler("", {{ $value }})
}
{{ end -}}
var (
{{- range $key, $value := .Mapping }}
_ = http.RedirectHandler("", {{ $value }})
{{- end }}
)

{{ range $key, $value := .Mapping }}
func _() {
var resp http.Response
switch resp.StatusCode {
{{- range $key, $value := .Mapping }}
case {{ $key }}: // want `"{{ quoteMeta $key }}" can be replaced by {{ quoteMeta $value }}`
return
{{- end }}
}
}
{{ end -}}

{{ range $key, $value := .Mapping }}
func _() {
var resp http.Response
switch resp.StatusCode {
{{- range $key, $value := .Mapping }}
case {{ $value }}:
return
{{- end }}
}
}
{{ end -}}

{{ range $key, $value := .Mapping }}
func _() {
var resp http.Response
switch {
{{- range $key, $value := .Mapping }}
case resp.StatusCode == {{ $key }}: // want `"{{ quoteMeta $key }}" can be replaced by {{ quoteMeta $value }}`
return
{{- end }}
}
}
{{ end -}}

{{ range $key, $value := .Mapping }}
func _() {
var resp http.Response
switch {
{{- range $key, $value := .Mapping }}
case resp.StatusCode == {{ $value }}:
return
{{- end }}
}
}
{{ end -}}

{{ range $key, $value := .Mapping }}
func _() {
_ = httptest.ResponseRecorder{
Code: {{ $key }}, // want `"{{ quoteMeta $key }}" can be replaced by {{ quoteMeta $value }}`
}
}
{{ end -}}
var (
{{- range $key, $value := .Mapping }}
_ = httptest.ResponseRecorder{Code: {{ $key }}} // want `"{{ quoteMeta $key }}" can be replaced by {{ quoteMeta $value }}`
{{- end }}
)

{{ range $key, $value := .Mapping }}
func _() {
_ = httptest.ResponseRecorder{
Code: {{ $value }},
}
}
{{ end -}}
var (
{{- range $key, $value := .Mapping }}
_ = httptest.ResponseRecorder{Code: {{ $value }}}
{{- end }}
)
12 changes: 9 additions & 3 deletions pkg/analyzer/internal/template/test-issue32.go.tmpl
View file
Expand Up @@ -18,18 +18,24 @@ const (

var (
{{- range $key, $value := .Mapping }}
_, _ = http.NewRequest("{{ toLower $key }}", "", http.NoBody) // want `"{{ quoteMeta (toLower $key) }}" can be replaced by {{ quoteMeta $value }}`
_ = http.Request{Method: "{{ toLower $key }}"} // want `"{{ quoteMeta (toLower $key) }}" can be replaced by {{ quoteMeta $value }}`
{{- end }}
)

var (
{{- range $key, $value := .Mapping }}
_, _ = http.NewRequestWithContext(nil, "{{ toLower $key }}", "", http.NoBody) // want `"{{ quoteMeta (toLower $key) }}" can be replaced by {{ quoteMeta $value }}`
_ = &http.Request{Method: "{{ toLower $key }}"} // want `"{{ quoteMeta (toLower $key) }}" can be replaced by {{ quoteMeta $value }}`
{{- end }}
)

var (
{{- range $key, $value := .Mapping }}
_ = &http.Request{Method: "{{ toLower $key }}"} // want `"{{ quoteMeta (toLower $key) }}" can be replaced by {{ quoteMeta $value }}`
_, _ = http.NewRequest("{{ toLower $key }}", "", http.NoBody) // want `"{{ quoteMeta (toLower $key) }}" can be replaced by {{ quoteMeta $value }}`
{{- end }}
)

var (
{{- range $key, $value := .Mapping }}
_, _ = http.NewRequestWithContext(nil, "{{ toLower $key }}", "", http.NoBody) // want `"{{ quoteMeta (toLower $key) }}" can be replaced by {{ quoteMeta $value }}`
{{- end }}
)
16 changes: 2 additions & 14 deletions pkg/analyzer/internal/template/test-template.go.tmpl
View file
Expand Up @@ -2,8 +2,6 @@

package {{ .PackageName }}

import "fmt"

var (
{{- range $key, $value := .Mapping }}
_ = "{{ $key }}" // want `"{{ quoteMeta $key }}" can be replaced by {{ quoteMeta $value }}`
Expand All @@ -16,18 +14,8 @@ const (
{{- end }}
)

func _() {
var (
{{- range $key, $value := .Mapping }}
_ = func(s string)string{return s}("{{ $key }}") // want `"{{ quoteMeta $key }}" can be replaced by {{ quoteMeta $value }}`
_ = func(s string)string{return s}("text before key {{ $key }}")
_ = func(s string)string{return s}("{{ $key }} text after key")
{{- end }}
}

func _() {
{{- range $key, $value := .Mapping }}
_ = fmt.Sprint("{{ $key }}") // want `"{{ quoteMeta $key }}" can be replaced by {{ quoteMeta $value }}`
_ = fmt.Sprint("text before key {{ $key }}")
_ = fmt.Sprint("{{ $key }} text after key")
{{- end }}
}
)
42 changes: 6 additions & 36 deletions pkg/analyzer/testdata/src/a/constant/kind.go
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit a3c2328

Please sign in to comment.