Merge pull request #48 from vsvastey/usr/vsvastey/redirect

feat: add check status code in http.Redirect
sashamelentyev · Aug 15, 2022 · 7c6dfe6 · 7c6dfe6
2 parents 8ac2a02 + 27b9021
commit 7c6dfe6
Show file tree

Hide file tree

Showing 3 changed files with 769 additions and 0 deletions.
diff --git a/pkg/analyzer/analyzer.go b/pkg/analyzer/analyzer.go
@@ -107,6 +107,15 @@ func run(pass *analysis.Pass) (interface{}, error) {
 					if basicLit := getBasicLitFromArgs(n.Args, 1, 0, token.INT); basicLit != nil {
 						checkHTTPStatusCode(pass, basicLit)
 					}
+
+				case "Redirect":
+					if !lookupFlag(pass, HTTPStatusCodeFlag) {
+						return
+					}
+
+					if basicLit := getBasicLitFromArgs(n.Args, 4, 3, token.INT); basicLit != nil {
+						checkHTTPStatusCode(pass, basicLit)
+					}
 				}
 			default:
 				if selectorExpr.Sel.Name == "WriteHeader" {

diff --git a/pkg/analyzer/internal/template/test-httpstatuscode.go.tmpl b/pkg/analyzer/internal/template/test-httpstatuscode.go.tmpl
@@ -98,3 +98,19 @@ func _() {
     http.StatusText({{ $value }})
 }
 {{ end -}}
+
+{{ range $key, $value := .Mapping }}
+func _() {
+    var w http.ResponseWriter
+    var r *http.Request
+    http.Redirect(w, r, "", {{ $key }}) // want `"{{ quoteMeta $key }}" can be replaced by {{ quoteMeta $value }}`
+}
+{{ end -}}
+
+{{ range $key, $value := .Mapping }}
+func _() {
+    var w http.ResponseWriter
+    var r *http.Request
+    http.Redirect(w, r, "", {{ $value }})
+}
+{{ end -}}