Skip to content

Commit

Permalink
Merge pull request kubernetes#3345 from trierra/kep-beta-125
Browse files Browse the repository at this point in the history
Promote Portworx CSI migration to Beta in v1.25
  • Loading branch information
k8s-ci-robot committed Jun 15, 2022
2 parents a3f5900 + 039705f commit 09ab36a
Show file tree
Hide file tree
Showing 2 changed files with 36 additions and 3 deletions.
35 changes: 34 additions & 1 deletion keps/sig-storage/2589-csi-migration-portworx/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@
- [New Feature Gates](#new-feature-gates)
- [Production Readiness Review Questionnaire](#production-readiness-review-questionnaire)
- [Implementation History](#implementation-history)
- [Design details](#design-details)
- [Test Plan](#test-plan)
- [Prerequisite testing updates](#prerequisite-testing-updates)
- [Unit tests](#unit-tests)
- [Integration tests](#integration-tests)
- [e2e tests](#e2e-tests)
<!-- /toc -->


Expand Down Expand Up @@ -50,6 +56,33 @@ Major milestones for Portworx in-tree plugin CSI migration:

- 1.23
- Portworx CSI migration to Alpha
- 1.24
- 1.25
- Portworx CSI migration to Beta, off by default

## Design details

### Test Plan

I/we understand the owners of the involved components may require updates to
existing tests to make this code solid enough prior to committing the changes necessary
to implement this enhancement.

##### Prerequisite testing updates

No additional tests are needed, rather the issue is orchestrating CSI driver
deployment for prow jobs. This has been complicated by the storage provider
extraction work, which no longer permits storage provider specific orchestration
in the k/k repository. This means that it is not possible to run any test for
portworx-volume in k/k.

##### Unit tests

See tests in the [https://github.com/kubernetes/csi-translation-lib/blob/master/plugins/portworx_test.go](https://github.com/kubernetes/csi-translation-lib/blob/master/plugins/portworx_test.go)

##### Integration tests

N/A

##### e2e tests

To ensure the implementation correctness, I/we have manually run the e2e tests, [located in the main k8s repository](https://github.com/kubernetes/kubernetes/blob/master/test/e2e/storage/drivers/in_tree.go). Test results are attached to the pull requests
4 changes: 2 additions & 2 deletions keps/sig-storage/2589-csi-migration-portworx/kep.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,12 @@ stage: beta
# The most recent milestone for which work toward delivery of this KEP has been
# done. This can be the current (upcoming) milestone, if it is being actively
# worked on.
latest-milestone: "v1.24"
latest-milestone: "v1.25"

# The milestone at which this feature was, or is targeted to be, at each stage.
milestone:
alpha: "v1.23"
beta: "v1.24"
beta: "v1.25"

# The following PRR answers are required at alpha release
# List the feature gate name and the components for which it must be enabled
Expand Down

0 comments on commit 09ab36a

Please sign in to comment.