Correct detect proc by raising exception eagerly #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
uranusjr
changed the title
A generator's content isn't accessed until it's first called next() against, which delays the exception from being raised. This messes up our proc vs ps detection logic. By wrapping the generator in a nested function, we can make the detection eager again and resolve the issue.
uranusjr
force-pushed
the
bugfix-detect-proc
branch
from
c9d25e2
to
4619ac9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #78
The problem was from changing the
impl.iter_process_parentsto a generator rather than a plan old iterator. The body of generators isn't evaluated until the first time theirnextmethod is called, so the check here:shellingham/src/shellingham/posix/__init__.py
Lines 46 to 47 in bf9f580
is incorrect because the environment error is raised here instead:
shellingham/src/shellingham/posix/__init__.py
Line 108 in bf9f580
or, when the generator is unpacked.
The fix is to just wrap the inner generator - so the
detect_procfunction is called in the expected place, and if it passes then the called generator is returned and equivalant to the current generator