New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "nu" to _core.py to support detect NuShell #56

Merged

uranusjr merged 1 commit into sarugaku:master from gunungpw:gunungpw-patch-1

Mar 24, 2022

Contributor

gunungpw commented Mar 24, 2022 •

edited

Hello Thank you for your project,
I am poetry user. Poetry use shellingham to detect shell for activating virtual environment. NuShell cannot the detected by poetry in Windows 10 show this PR fix that.

after the change shellingham can detect nushell:

D:\GitHub\demo-shellingham\demo_shellingham〉bat -p .\check.py                                                                                    03/24/2022 11:01:34 AM
import shellingham
print(shellingham.detect_shell())

D:\GitHub\demo-shellingham\demo_shellingham〉python .\check.py                                                                                    03/24/2022 11:01:43 AM
('nu', 'C:\\Program Files\\nu\\bin\\nu.exe')
D:\GitHub\demo-shellingham\demo_shellingham〉                                                                                                     03/24/2022 11:01:51 AM

Hope you all have a nice day 👍


          Add "nu" to _core.py to support detect NuShell

4430c17

add NuShell to the list of shell

gunungpw mentioned this pull request

poetry shell not use nushell when spawning shell for virtual environment python-poetry/poetry#5349

Closed

3 tasks

uranusjr approved these changes

View reviewed changes

Contributor Author

gunungpw commented Mar 24, 2022

Thank you 🙏

uranusjr merged commit 23cb5cb into sarugaku:master

gunungpw deleted the gunungpw-patch-1 branch

March 24, 2022 05:44

adrianstaniec commented May 16, 2022

(when) will these be released in new package version? :)

Member

uranusjr commented May 16, 2022

Yes, once I get time for it. (Sorry it has been some busy months.)

ofek mentioned this pull request

New release #57

Closed

github-actions bot added a commit to MaRDI4NFDI/open-interfaces that referenced this pull request


          ⬆️ Bump shellingham from 1.4.0 to 1.5.0 (#5)

8f1aeed

Bumps [shellingham](https://github.com/sarugaku/shellingham) from 1.4.0
to 1.5.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/sarugaku/shellingham/releases">shellingham's
releases</a>.</em></p>
<blockquote>
<h2>1.5.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Bump bleach from 3.2.1 to 3.3.0 by <a
href="https://github.com/dependabot"><code>@dependabot</code></a> in <a
href="https://github-redirect.dependabot.com/sarugaku/shellingham/pull/44">sarugaku/shellingham#44</a></li>
<li>Bump cryptography from 3.3.1 to 3.3.2 by <a
href="https://github.com/dependabot"><code>@dependabot</code></a> in <a
href="https://github-redirect.dependabot.com/sarugaku/shellingham/pull/45">sarugaku/shellingham#45</a></li>
<li>Bump urllib3 from 1.26.3 to 1.26.4 by <a
href="https://github.com/dependabot"><code>@dependabot</code></a> in <a
href="https://github-redirect.dependabot.com/sarugaku/shellingham/pull/46">sarugaku/shellingham#46</a></li>
<li>Modern python by <a
href="https://github.com/JeppeKlitgaard"><code>@JeppeKlitgaard</code></a>
in <a
href="https://github-redirect.dependabot.com/sarugaku/shellingham/pull/50">sarugaku/shellingham#50</a></li>
<li>Update README.rst by <a
href="https://github.com/davidlatwe"><code>@davidlatwe</code></a> in <a
href="https://github-redirect.dependabot.com/sarugaku/shellingham/pull/51">sarugaku/shellingham#51</a></li>
<li>Bump urllib3 from 1.26.4 to 1.26.5 by <a
href="https://github.com/dependabot"><code>@dependabot</code></a> in <a
href="https://github-redirect.dependabot.com/sarugaku/shellingham/pull/54">sarugaku/shellingham#54</a></li>
<li>Add &quot;nu&quot; to _core.py to support detect NuShell by <a
href="https://github.com/gunungpw"><code>@gunungpw</code></a> in <a
href="https://github-redirect.dependabot.com/sarugaku/shellingham/pull/56">sarugaku/shellingham#56</a></li>
<li>Fix typos by <a
href="https://github.com/kianmeng"><code>@kianmeng</code></a> in <a
href="https://github-redirect.dependabot.com/sarugaku/shellingham/pull/58">sarugaku/shellingham#58</a></li>
<li>Add release job by <a
href="https://github.com/ofek"><code>@ofek</code></a> in <a
href="https://github-redirect.dependabot.com/sarugaku/shellingham/pull/59">sarugaku/shellingham#59</a></li>
<li>chore: prepare for release 1.5.0 by <a
href="https://github.com/frostming"><code>@frostming</code></a> in <a
href="https://github-redirect.dependabot.com/sarugaku/shellingham/pull/60">sarugaku/shellingham#60</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a
href="https://github.com/JeppeKlitgaard"><code>@JeppeKlitgaard</code></a>
made their first contribution in <a
href="https://github-redirect.dependabot.com/sarugaku/shellingham/pull/50">sarugaku/shellingham#50</a></li>
<li><a
href="https://github.com/davidlatwe"><code>@davidlatwe</code></a> made
their first contribution in <a
href="https://github-redirect.dependabot.com/sarugaku/shellingham/pull/51">sarugaku/shellingham#51</a></li>
<li><a href="https://github.com/gunungpw"><code>@gunungpw</code></a>
made their first contribution in <a
href="https://github-redirect.dependabot.com/sarugaku/shellingham/pull/56">sarugaku/shellingham#56</a></li>
<li><a href="https://github.com/kianmeng"><code>@kianmeng</code></a>
made their first contribution in <a
href="https://github-redirect.dependabot.com/sarugaku/shellingham/pull/58">sarugaku/shellingham#58</a></li>
<li><a href="https://github.com/ofek"><code>@ofek</code></a> made their
first contribution in <a
href="https://github-redirect.dependabot.com/sarugaku/shellingham/pull/59">sarugaku/shellingham#59</a></li>
<li><a href="https://github.com/frostming"><code>@frostming</code></a>
made their first contribution in <a
href="https://github-redirect.dependabot.com/sarugaku/shellingham/pull/60">sarugaku/shellingham#60</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/sarugaku/shellingham/compare/1.4.0...1.5.0">https://github.com/sarugaku/shellingham/compare/1.4.0...1.5.0</a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/sarugaku/shellingham/blob/master/CHANGELOG.rst">shellingham's
changelog</a>.</em></p>
<blockquote>
<h1>1.5.0 (2022-08-04)</h1>
<h2>Features</h2>
<ul>
<li>Drop support for Python version older than 3.4.
<code>[#50](sarugaku/shellingham#50)
&lt;https://github.com/sarugaku/shellingham/issues/50&gt;</code>_</li>
<li>Support detecting NuShell.
<code>[#56](sarugaku/shellingham#56)
&lt;https://github.com/sarugaku/shellingham/issues/56&gt;</code>_</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/sarugaku/shellingham/commit/ace45254557977bb8d0a7c511d16c074ec95576b"><code>ace4525</code></a>
chore: prepare for release 1.5.0 (<a
href="https://github-redirect.dependabot.com/sarugaku/shellingham/issues/60">#60</a>)</li>
<li><a
href="https://github.com/sarugaku/shellingham/commit/b68e3dfa4bd29e2c6c2b91361874cceb05ff1ebf"><code>b68e3df</code></a>
Add release job (<a
href="https://github-redirect.dependabot.com/sarugaku/shellingham/issues/59">#59</a>)</li>
<li><a
href="https://github.com/sarugaku/shellingham/commit/6025d916884af7e769e44a5f2483272eb4dae2e9"><code>6025d91</code></a>
Fix typos (<a
href="https://github-redirect.dependabot.com/sarugaku/shellingham/issues/58">#58</a>)</li>
<li><a
href="https://github.com/sarugaku/shellingham/commit/23cb5cbacaf86fd9e32368b1531e281607b32d13"><code>23cb5cb</code></a>
Add &quot;nu&quot; to _core.py to support detect NuShell (<a
href="https://github-redirect.dependabot.com/sarugaku/shellingham/issues/56">#56</a>)</li>
<li><a
href="https://github.com/sarugaku/shellingham/commit/325c643e89877eb325adf44bc62547251e87acef"><code>325c643</code></a>
Bump urllib3 from 1.26.4 to 1.26.5 (<a
href="https://github-redirect.dependabot.com/sarugaku/shellingham/issues/54">#54</a>)</li>
<li><a
href="https://github.com/sarugaku/shellingham/commit/32a9891799e1ac6e6f97e4c6530e2824a00ce456"><code>32a9891</code></a>
Update README.rst (<a
href="https://github-redirect.dependabot.com/sarugaku/shellingham/issues/51">#51</a>)</li>
<li><a
href="https://github.com/sarugaku/shellingham/commit/f26a196c583fc011f1c845af7cdcfe199150326d"><code>f26a196</code></a>
Merge pull request <a
href="https://github-redirect.dependabot.com/sarugaku/shellingham/issues/50">#50</a>
from JeppeKlitgaard/modern_python</li>
<li><a
href="https://github.com/sarugaku/shellingham/commit/1aa948f56d05945dfc4fa77742e373da4cc52010"><code>1aa948f</code></a>
Drop support for old Python versions</li>
<li><a
href="https://github.com/sarugaku/shellingham/commit/4cea54f46fc018b084612105ddcd86480ba1225f"><code>4cea54f</code></a>
feat: Test matrix</li>
<li><a
href="https://github.com/sarugaku/shellingham/commit/718d24478a484747c6519eb0c0ff08219acc6e9f"><code>718d244</code></a>
feat: Add python 3.7, 3.8, 3.9, 3.10 support</li>
<li>Additional commits viewable in <a
href="https://github.com/sarugaku/shellingham/compare/1.4.0...1.5.0">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=shellingham&package-manager=pip&previous-version=1.4.0&new-version=1.5.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment