Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: isJSONEncodable doesn't belong to discord.js #497

Closed
wants to merge 4 commits into from
Closed

fix: isJSONEncodable doesn't belong to discord.js #497

wants to merge 4 commits into from

Conversation

chikof
Copy link

@chikof chikof commented Oct 9, 2022 •
edited

I was trying to migrate to discord.js v14 and I got that error.

@simxnet

This comment was marked as off-topic.

Sign in to view
favna
favna approved these changes Oct 9, 2022
View reviewed changes
Copy link
Member

@favna favna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DJS does re-export it but I guess this is better

@simxnet

This comment was marked as off-topic.

Sign in to view
@chikof
Copy link
Author

chikof commented Oct 9, 2022 •
edited

DJS does not, I was looking in the code and found nothing. 🤔

@simxnet

This comment was marked as off-topic.

Sign in to view
@vladfrangu
Copy link
Member

Eh, I am neutral about merging this because d.js re-exports everything from builders anyways (https://github.com/discordjs/discord.js/blob/main/packages/discord.js/src/index.js#L187), but I'll leave it to @favna

@favna
Copy link
Member

favna commented Oct 9, 2022

DJS does not, I was looking in the code and found nothing. 🤔

https://github.com/discordjs/discord.js/blob/5f72d8b645db095605ded58865760d62164e52b8/packages/discord.js/src/index.js#L187

@chikof
Copy link
Author

chikof commented Oct 9, 2022

uhm

@chikof
Copy link
Author

chikof commented Oct 9, 2022 •
edited

But I still got an error, I tried modifying the files as I did in this PR and it worked.
image

discord.js@14.5.0
@sapphire/discord.js-utilities@pr-434 (5.1.0-pr-434.9fcf7df.0)

@favna
Copy link
Member

favna commented Oct 9, 2022

Weird it should definitely be in 14.5.0. These are the changes between 14.5.0 and main: discordjs/discord.js@14.5.0...main#diff-ebb64b5f12

@imranbarbhuiya
Copy link
Contributor

yeah it was fixed in discordjs/discord.js#8699

@chikof
Copy link
Author

chikof commented Oct 9, 2022

so, that means it's fixed in the dev version

@favna
Copy link
Member

favna commented Oct 9, 2022

so, that means it's fixed in the dev version

Correct

@chikof @favna
Update packages/discord.js-utilities/src/lib/PaginatedMessages/Pagina…
827e76b 
…tedMessage.ts

Co-authored-by: Jeroen Claassens <jeroen.claassens@live.nl>
@imranbarbhuiya
Copy link
Contributor

A new release with the fix is available now. So just update the djs version and it'll be fixed

@chikof chikof closed this Oct 10, 2022
@chikof chikof deleted the feat/djs-v14 branch October 10, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@favna favna favna approved these changes

@simxnet simxnet simxnet approved these changes

@kyranet kyranet Awaiting requested review from kyranet

@vladfrangu vladfrangu Awaiting requested review from vladfrangu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@chikof @simxnet @vladfrangu @favna @imranbarbhuiya