forked from infection/infection
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use coverage report as a primary source of files to mutate
This PR is a continuation of infection#1082. Primary goal of this PR is memory optimization. Fixes infection#705. With big projects with huge coverage reports Infection still has a lot of difficulty. Major part of this problem stems from the fact that Infection loads virtually all PHPUnit coverage reports at the start, and then goes one by one over source files looking up each file in the reports to understand if it need mutating, where, how, and so on. Not only it is expensive to load all reports at once, but also working with them isn't fast. Basically, it is one big hash table, where Infection tries to access rows from here and from there. - Yes, it may worth adding a cache, because, say, methods of XMLLineCodeCoverage are called sequentially over data for the same file, but this isn't what I want to propose. - Yes, with some careful ArrayAccess application you can make the $coverage array clever to load data only as needed, and neither this is what I want to propose. What's the idea? If you'd look at the PHPUnit coverage reports, and how we parse them, you would notice that the coverage reports have the same file names we need. Therefore, instead of iterating over files on disk, we can iterate over coverage reports, parsing them one by one, and discarding them once we finish mutating a file. There are some problems: - We not only consider these reports, we also consider JUnit reports, joining them together. This procedure had to be split into two. First we load coverage files, select files we want to be mutated (covered, uncovered, filtered), and only then we add JUnit timings, proceeding with mutation. - For BC reasons we have to consider files outside of coverage reports, therefore we collect them too, adding missing files at the end, but only if needed. Suffice to say if we'd went half-way towards proposal infection#1064, this part could be removed from our pipeline, chances are together with the configuration step where user enters source paths. - Overall I had to reshuffle a lot of things, while trying to not to rename them too much. E.g. old tests for the new parser should probably work, and so on.
- Loading branch information
Showing
21 changed files
with
948 additions
and
522 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,111 @@ | ||
| <?php | ||
| /** | ||
| * This code is licensed under the BSD 3-Clause License. | ||
| * | ||
| * Copyright (c) 2017, Maks Rafalko | ||
| * All rights reserved. | ||
| * | ||
| * Redistribution and use in source and binary forms, with or without | ||
| * modification, are permitted provided that the following conditions are met: | ||
| * | ||
| * * Redistributions of source code must retain the above copyright notice, this | ||
| * list of conditions and the following disclaimer. | ||
| * | ||
| * * Redistributions in binary form must reproduce the above copyright notice, | ||
| * this list of conditions and the following disclaimer in the documentation | ||
| * and/or other materials provided with the distribution. | ||
| * | ||
| * * Neither the name of the copyright holder nor the names of its | ||
| * contributors may be used to endorse or promote products derived from | ||
| * this software without specific prior written permission. | ||
| * | ||
| * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" | ||
| * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE | ||
| * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE | ||
| * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE | ||
| * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL | ||
| * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR | ||
| * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER | ||
| * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, | ||
| * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | ||
| * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
| */ | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Infection\FileSystem; | ||
|
|
||
| use function explode; | ||
| use Infection\FileSystem\Finder\Iterator\RealPathFilterIterator; | ||
| use Infection\TestFramework\Coverage\CoveredFileData; | ||
| use Iterator; | ||
| use function Pipeline\take; | ||
| use Symfony\Component\Finder\SplFileInfo; | ||
|
|
||
| /** | ||
| * @internal | ||
| */ | ||
| final class SourceFileFilter | ||
| { | ||
| /** | ||
| * @var string[] | ||
| */ | ||
| private $filters; | ||
|
|
||
| /** | ||
| * @return iterable<SplFileInfo> | ||
| */ | ||
| public function __construct(string $filter) | ||
| { | ||
| $this->filters = take(explode(',', $filter)) | ||
| ->map('trim') | ||
| ->filter() | ||
| ->toArray(); | ||
| } | ||
|
|
||
| /** | ||
| * @return string[] | ||
| * | ||
| * @see SourceFileCollector | ||
| */ | ||
| public function getFilters(): array | ||
| { | ||
| return $this->filters; | ||
| } | ||
|
|
||
| /** | ||
| * @param iterable<SplFileInfo&CoveredFileData> $input | ||
| * | ||
| * @return iterable<SplFileInfo&CoveredFileData> | ||
| */ | ||
| public function filter(iterable $input): iterable | ||
| { | ||
| if ($this->filters === []) { | ||
| return $input; | ||
| } | ||
|
|
||
| return new RealPathFilterIterator( | ||
| $this->iterableToIterator($input), | ||
| $this->filters, | ||
| [] | ||
| ); | ||
| } | ||
|
|
||
| /** | ||
| * @param iterable<SplFileInfo&CoveredFileData> $input | ||
| * | ||
| * @return Iterator<SplFileInfo&CoveredFileData> | ||
| */ | ||
| private function iterableToIterator(iterable $input) | ||
| { | ||
| if ($input instanceof Iterator) { | ||
| // Generator is an iterator, means most of the time we're done right here. | ||
| return $input; | ||
| } | ||
|
|
||
| // Clause for all other cases, e.g. when testing | ||
| return (static function () use ($input): Iterator { | ||
| yield from $input; | ||
| })(); | ||
| } | ||
| } |
Oops, something went wrong.