Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix DeprecationWarning: Attribute s is deprecated and will be removed… #2926

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix DeprecationWarning: Attribute s is deprecated and will be removed… #2926

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0bc7189
fix DeprecationWarning: Attribute s is deprecated and will be removed…
Mar 14, 2024
8ca200b
Fix version compatibility issue in 'ode.py'
Mar 25, 2024
457fa57
Merge branch 'main' into fix-Deprecation-warning
ahopkins Apr 1, 2024
d2f7541
Merge branch 'main' into fix-Deprecation-warning
ahopkins Apr 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion sanic/touchup/schemes/ode.py
View file
Open in desktop
@@ -1,3 +1,4 @@
import sys
from ast import Attribute, Await, Expr, NodeTransformer
from typing import Any, List

Expand Down Expand Up @@ -67,7 +68,7 @@ def visit_Expr(self, node: Expr) -> Any:

if isinstance(func, Attribute) and func.attr == "dispatch":
event = args[0]
if hasattr(event, "s"):
if hasattr(event, "value") if sys.version_info >= (3, 12) else hasattr(event, "s"):
event_name = getattr(event, "value", event.s)
if self._not_registered(event_name):
logger.debug(
Expand Down