Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass unquote thru add_route #2639

Merged
merged 2 commits into from Dec 21, 2022
Merged

Pass unquote thru add_route #2639

merged 2 commits into from Dec 21, 2022

Conversation

ahopkins
Copy link
Member

Needed for fix for: sanic-org/sanic-ext#148, but we probably should be accepting this param here anyway.

@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Base: 88.596% // Head: 88.640% // Increases project coverage by +0.044% 🎉

Coverage data is based on head (981b57e) compared to base (2abe66b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2639       +/-   ##
=============================================
+ Coverage   88.596%   88.640%   +0.044%     
=============================================
  Files           82        82               
  Lines         6761      6761               
  Branches      1156      1156               
=============================================
+ Hits          5990      5993        +3     
+ Misses         531       529        -2     
+ Partials       240       239        -1     
Impacted Files Coverage Δ
sanic/mixins/routes.py 94.881% <ø> (ø)
sanic/server/websockets/impl.py 37.557% <0.000%> (-0.231%) ⬇️
sanic/app.py 90.070% <0.000%> (+0.709%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ahopkins ahopkins merged commit 029f564 into main Dec 21, 2022
@ahopkins ahopkins deleted the issue148-sanic-ext branch December 21, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant