Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double ctrl-c kill #2634

Merged
merged 2 commits into from Dec 18, 2022
Merged

Fix double ctrl-c kill #2634

merged 2 commits into from Dec 18, 2022

Conversation

ahopkins
Copy link
Member

#2621 Added SIGKILL to the second ctrl+c. But, this only worked on route handler delays and not listeners. By moving the logic from terminated to shutting_down, we are targeting the intended behavior and for both scenarios.

@ahopkins ahopkins requested a review from a team as a code owner December 18, 2022 11:34
@codecov
Copy link

codecov bot commented Dec 18, 2022

Codecov Report

Base: 88.526% // Head: 88.659% // Increases project coverage by +0.133% 🎉

Coverage data is based on head (853ff61) compared to base (f7040cc).
Patch coverage: 100.000% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2634       +/-   ##
=============================================
+ Coverage   88.526%   88.659%   +0.133%     
=============================================
  Files           82        82               
  Lines         6746      6746               
  Branches      1152      1152               
=============================================
+ Hits          5972      5981        +9     
+ Misses         532       528        -4     
+ Partials       242       237        -5     
Impacted Files Coverage Δ
sanic/worker/manager.py 94.047% <100.000%> (+2.976%) ⬆️
sanic/worker/process.py 89.090% <0.000%> (-1.819%) ⬇️
sanic/http/http1.py 83.561% <0.000%> (-0.685%) ⬇️
sanic/server/websockets/impl.py 38.479% <0.000%> (+0.691%) ⬆️
sanic/app.py 89.836% <0.000%> (+0.725%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ahopkins ahopkins merged commit 4744a89 into main Dec 18, 2022
@ahopkins ahopkins deleted the fix-kill-double-ctrl-c branch December 18, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant