Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload interval on class variable #2633

Merged
merged 1 commit into from Dec 18, 2022
Merged

Reload interval on class variable #2633

merged 1 commit into from Dec 18, 2022

Conversation

ahopkins
Copy link
Member

@ahopkins ahopkins commented Dec 18, 2022

Replaces #2567 by moving the interval to the class so that it is possible to configure, but does not bloat the config namespace.

from sanic.worker.reloader import Reloader

Reloader.INTERVAL = 5.0

@codecov
Copy link

codecov bot commented Dec 18, 2022

Codecov Report

Base: 88.539% // Head: 88.555% // Increases project coverage by +0.016% 🎉

Coverage data is based on head (573fe95) compared to base (0e44e9c).
Patch coverage: 100.000% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2633       +/-   ##
=============================================
+ Coverage   88.539%   88.555%   +0.016%     
=============================================
  Files           81        81               
  Lines         6701      6702        +1     
  Branches      1143      1143               
=============================================
+ Hits          5933      5935        +2     
+ Misses         529       528        -1     
  Partials       239       239               
Impacted Files Coverage Δ
sanic/mixins/startup.py 91.196% <100.000%> (ø)
sanic/worker/reloader.py 97.101% <100.000%> (+0.042%) ⬆️
sanic/http/http1.py 84.246% <0.000%> (+0.684%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ahopkins ahopkins merged commit 518152d into main Dec 18, 2022
@ahopkins ahopkins deleted the reload-interval branch December 18, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant