Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated distutils.strtobool #2628

Merged
merged 2 commits into from Dec 16, 2022
Merged

Conversation

kijk2869
Copy link
Contributor

Fix #2388

Because setup.py also uses the function, code duplication inevitably occurred.
If there is a better solution, please suggest.

@kijk2869 kijk2869 requested review from a team as code owners December 16, 2022 00:40
@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Base: 88.548% // Head: 88.489% // Decreases project coverage by -0.059% ⚠️

Coverage data is based on head (0a1a1d2) compared to base (71d3d87).
Patch coverage: 100.000% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2628       +/-   ##
=============================================
- Coverage   88.548%   88.489%   -0.060%     
=============================================
  Files           81        81               
  Lines         6698      6698               
  Branches      1143      1143               
=============================================
- Hits          5931      5927        -4     
- Misses         529       531        +2     
- Partials       238       240        +2     
Impacted Files Coverage Δ
sanic/server/loop.py 57.692% <100.000%> (ø)
sanic/server/websockets/impl.py 37.557% <0.000%> (-0.922%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@ahopkins ahopkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplication is 👌

@ahopkins ahopkins merged commit 95ee518 into sanic-org:main Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

distutils.strtobool deprecation
2 participants