Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASGI lifespan failure on exception #2627

Merged
merged 4 commits into from Dec 16, 2022
Merged

ASGI lifespan failure on exception #2627

merged 4 commits into from Dec 16, 2022

Conversation

ahopkins
Copy link
Member

Closes #2392

@ahopkins ahopkins marked this pull request as ready for review December 15, 2022 20:32
@ahopkins ahopkins requested a review from a team as a code owner December 15, 2022 20:32
@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Base: 88.489% // Head: 88.532% // Increases project coverage by +0.043% 🎉

Coverage data is based on head (51f715e) compared to base (95ee518).
Patch coverage: 100.000% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2627       +/-   ##
=============================================
+ Coverage   88.489%   88.532%   +0.043%     
=============================================
  Files           81        81               
  Lines         6698      6706        +8     
  Branches      1143      1143               
=============================================
+ Hits          5927      5937       +10     
  Misses         531       531               
+ Partials       240       238        -2     
Impacted Files Coverage Δ
sanic/asgi.py 92.307% <100.000%> (+2.143%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ahopkins ahopkins merged commit a3ff0c1 into main Dec 16, 2022
@ahopkins ahopkins deleted the issue2392 branch December 16, 2022 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uvicorn ignores listeners errors
2 participants