Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fork in limited cases #2624

Merged
merged 16 commits into from Dec 15, 2022
Merged

Allow fork in limited cases #2624

merged 16 commits into from Dec 15, 2022

Conversation

ahopkins
Copy link
Member

@ahopkins ahopkins commented Dec 11, 2022

Supporting both fork and spawn is a PITA. For reasons that drove us towards the big change in v22.9, spawn should always be the default. This PR will not drop back to fork unless someone expressly chooses it. For more information on why, see: https://community.sanicframework.org/t/sanic-app-name-xxx-already-in-use-while-running-in-docker

@ahopkins ahopkins requested a review from a team as a code owner December 11, 2022 11:03
@ahopkins
Copy link
Member Author

This pull request has been mentioned on Sanic Community Discussion. There might be relevant details there:

https://community.sanicframework.org/t/sanic-app-name-xxx-already-in-use-while-running-in-docker/1106/7

@ahopkins ahopkins changed the title Add app clear to the loader on factory Allow fork in limited cases Dec 11, 2022
@ahopkins ahopkins marked this pull request as draft December 11, 2022 14:03
@codecov
Copy link

codecov bot commented Dec 11, 2022

Codecov Report

Base: 88.614% // Head: 88.512% // Decreases project coverage by -0.102% ⚠️

Coverage data is based on head (2626be3) compared to base (db39e12).
Patch coverage: 73.333% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2624       +/-   ##
=============================================
- Coverage   88.614%   88.512%   -0.103%     
=============================================
  Files           81        81               
  Lines         6684      6694       +10     
  Branches      1142      1143        +1     
=============================================
+ Hits          5923      5925        +2     
- Misses         524       529        +5     
- Partials       237       240        +3     
Impacted Files Coverage Δ
sanic/worker/manager.py 90.506% <20.000%> (-2.305%) ⬇️
sanic/application/ext.py 100.000% <100.000%> (ø)
sanic/mixins/startup.py 90.990% <100.000%> (+0.102%) ⬆️
sanic/server/websockets/impl.py 37.557% <0.000%> (-0.922%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ahopkins ahopkins marked this pull request as ready for review December 11, 2022 21:06
@ahopkins ahopkins merged commit b276b91 into main Dec 15, 2022
@ahopkins ahopkins deleted the clear-apps branch December 15, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant