New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wait for new process to ACK before termination of old on restart #2623
Conversation
tests/worker/test_reloader.py
Outdated
with caplog.at_level(DEBUG): | ||
worker_process.restart() | ||
|
||
ansi = re.compile(r"\x1B(?:[@-Z\\-_]|\[[0-?]*[ -/]*[@-~])") |
Check warning
Code scanning / CodeQL
Overly permissive regular expression range
tests/worker/test_reloader.py
Outdated
with caplog.at_level(DEBUG): | ||
worker_process.restart() | ||
|
||
ansi = re.compile(r"\x1B(?:[@-Z\\-_]|\[[0-?]*[ -/]*[@-~])") |
Check warning
Code scanning / CodeQL
Overly permissive regular expression range
Codecov ReportBase: 88.568% // Head: 88.483% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2623 +/- ##
=============================================
- Coverage 88.568% 88.483% -0.086%
=============================================
Files 81 81
Lines 6631 6660 +29
Branches 1129 1135 +6
=============================================
+ Hits 5873 5893 +20
- Misses 522 527 +5
- Partials 236 240 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Going to put this on hold until #2626 is in. Using the new pattern there, we can remove this from a config setting and do it as a command feature. |
Current logic terminates a process (sends SIGINT), then starts a new process. This PR reverses the order so that it starts the new process, waits for ACK and then sends the SIGINT.
Closes #2619