Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a restart mechanism to all workers in the multiplexer #2622

Merged
merged 5 commits into from Dec 11, 2022
Merged

Conversation

ahopkins
Copy link
Member

@ahopkins ahopkins commented Dec 8, 2022

Closes #2619

This adds a app.m.restart(all_workers=True) flag.

@ahopkins ahopkins requested a review from a team as a code owner December 8, 2022 09:52
@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Base: 88.565% // Head: 88.568% // Increases project coverage by +0.003% 🎉

Coverage data is based on head (15ab517) compared to base (8e72036).
Patch coverage: 100.000% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2622       +/-   ##
=============================================
+ Coverage   88.565%   88.568%   +0.003%     
=============================================
  Files           81        81               
  Lines         6629      6631        +2     
  Branches      1128      1129        +1     
=============================================
+ Hits          5871      5873        +2     
  Misses         522       522               
  Partials       236       236               
Impacted Files Coverage Δ
sanic/worker/multiplexer.py 100.000% <100.000%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

prryplatypus
prryplatypus previously approved these changes Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

restart workers online (graceful restart) to hot reload, in production environment.
2 participants