Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a SIGKILL to second ctrl+c #2621

Merged
merged 5 commits into from Dec 14, 2022
Merged

Add a SIGKILL to second ctrl+c #2621

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6391864
Add a SIGKILL to second ctrl+c
ahopkins Dec 8, 2022
3c3cfb1
Remove unused line
ahopkins Dec 8, 2022
fa92475
Merge branch 'main' into killsig
ahopkins Dec 11, 2022
906207a
Merge conflicts
ahopkins Dec 14, 2022
dce6c26
Merge branch 'killsig' of github.com:sanic-org/sanic into killsig
ahopkins Dec 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion sanic/worker/manager.py
View file
Open in desktop
@@ -1,5 +1,6 @@
import os

from contextlib import suppress
from signal import SIGINT, SIGTERM, Signals
from signal import signal as signal_func
from typing import List, Optional
Expand Down Expand Up @@ -62,7 +63,6 @@ def run(self):
self.monitor()
self.join()
self.terminate()
# self.kill()

def start(self):
for process in self.processes:
Expand Down Expand Up @@ -183,6 +183,11 @@ def kill(self):
raise ServerKilled

def shutdown_signal(self, signal, frame):
if self.terminated:
logger.info("Shutdown interrupted. Killing.")
with suppress(ServerKilled):
self.kill()

ahopkins marked this conversation as resolved.
Show resolved Hide resolved
logger.info("Received signal %s. Shutting down.", Signals(signal).name)
self.monitor_publisher.send(None)
self.shutdown()
Expand Down