Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale workers #2617

Merged
merged 6 commits into from Dec 13, 2022
Merged

Scale workers #2617

merged 6 commits into from Dec 13, 2022

Conversation

ahopkins
Copy link
Member

@ahopkins ahopkins commented Dec 7, 2022

This PR adds the ability to scale from the inspector or the multiplexer.

Resolves #2616

@ahopkins ahopkins marked this pull request as ready for review December 12, 2022 21:37
@ahopkins ahopkins requested a review from a team as a code owner December 12, 2022 21:37
@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Base: 88.574% // Head: 88.614% // Increases project coverage by +0.040% 🎉

Coverage data is based on head (b8e4a7e) compared to base (13e9ab7).
Patch coverage: 95.312% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2617       +/-   ##
=============================================
+ Coverage   88.574%   88.614%   +0.040%     
=============================================
  Files           81        81               
  Lines         6634      6684       +50     
  Branches      1130      1142       +12     
=============================================
+ Hits          5876      5923       +47     
- Misses         522       524        +2     
- Partials       236       237        +1     
Impacted Files Coverage Δ
sanic/worker/manager.py 92.810% <94.000%> (-0.110%) ⬇️
sanic/worker/inspector.py 98.924% <100.000%> (+0.074%) ⬆️
sanic/worker/multiplexer.py 100.000% <100.000%> (ø)
sanic/worker/process.py 88.888% <100.000%> (+0.124%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ahopkins ahopkins merged commit db39e12 into main Dec 13, 2022
@ahopkins ahopkins deleted the worker-scale branch December 13, 2022 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to change worker amount online
1 participant