Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill server early on worker error #2610

Merged
merged 7 commits into from Dec 7, 2022
Merged

Kill server early on worker error #2610

merged 7 commits into from Dec 7, 2022

Conversation

ahopkins
Copy link
Member

@ahopkins ahopkins commented Nov 29, 2022

This will be to kill the worker process early on an error and to allow the deadlock restriction to be bumped to a higher value.

@ahopkins ahopkins marked this pull request as ready for review December 6, 2022 07:34
@ahopkins ahopkins requested a review from a team as a code owner December 6, 2022 07:34
Copy link
Contributor

@sjsadowski sjsadowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor things, I don't think they're blockers for merging though.

sanic/worker/manager.py Outdated Show resolved Hide resolved
tests/test_unix_socket.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Base: 87.945% // Head: 87.818% // Decreases project coverage by -0.127% ⚠️

Coverage data is based on head (3f4bcce) compared to base (0909e94).
Patch coverage: 84.615% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2610       +/-   ##
=============================================
- Coverage   87.945%   87.818%   -0.128%     
=============================================
  Files           71        71               
  Lines         5359      5377       +18     
  Branches       893       897        +4     
=============================================
+ Hits          4713      4722        +9     
- Misses         469       473        +4     
- Partials       177       182        +5     
Impacted Files Coverage Δ
sanic/mixins/startup.py 90.888% <33.333%> (-1.029%) ⬇️
sanic/worker/serve.py 91.176% <88.461%> (+1.521%) ⬆️
sanic/worker/manager.py 92.920% <100.000%> (+0.063%) ⬆️
sanic/worker/multiplexer.py 100.000% <100.000%> (ø)
sanic/server/websockets/impl.py 37.557% <0.000%> (-0.922%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ahopkins ahopkins merged commit f32437b into main Dec 7, 2022
@ahopkins ahopkins deleted the kill-early branch December 7, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants