Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require uvloop >= 0.15.0 #2598

Merged
merged 1 commit into from Nov 13, 2022
Merged

Require uvloop >= 0.15.0 #2598

merged 1 commit into from Nov 13, 2022

Conversation

ChihweiLHBird
Copy link
Member

@ChihweiLHBird ChihweiLHBird commented Nov 8, 2022

An issue (#2496) reported by @ancalita claims Sanic requires uvloop >= 0.15.0

During testing, the CI results (#2597) show that Sanic is broken with uvloop version less than 0.15.0

So, let's update the dependency requirement in setup.py to fix the issue.

uvloop PR: MagicStack/uvloop#334

@ChihweiLHBird ChihweiLHBird requested a review from a team as a code owner November 8, 2022 01:25
@ChihweiLHBird ChihweiLHBird requested a review from a team November 8, 2022 01:25
@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Base: 88.047% // Head: 88.047% // No change to project coverage 👍

Coverage data is based on head (ab78bda) compared to base (4422d0c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #2598   +/-   ##
=========================================
  Coverage   88.047%   88.047%           
=========================================
  Files           71        71           
  Lines         5338      5338           
  Branches       893       893           
=========================================
  Hits          4700      4700           
  Misses         461       461           
  Partials       177       177           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ChihweiLHBird ChihweiLHBird linked an issue Nov 8, 2022 that may be closed by this pull request
@ahopkins ahopkins merged commit ad4e526 into main Nov 13, 2022
@ahopkins ahopkins deleted the zhiwei/uvloop>=0.15.0 branch November 13, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade dependency version constraint specification for uvloop
2 participants