Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interval sleep in reloader #2595

Merged
merged 2 commits into from
Oct 31, 2022
Merged

Add interval sleep in reloader #2595

merged 2 commits into from
Oct 31, 2022

Conversation

ahopkins
Copy link
Member

Meant to fix #2566 until discussion in #2567 is complete.

@ahopkins ahopkins requested a review from a team as a code owner October 31, 2022 09:52
@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Base: 88.093% // Head: 88.097% // Increases project coverage by +0.004% 🎉

Coverage data is based on head (09e3da3) compared to base (1c4925e).
Patch coverage: 100.000% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2595       +/-   ##
=============================================
+ Coverage   88.093%   88.097%   +0.004%     
=============================================
  Files           71        71               
  Lines         5333      5335        +2     
  Branches       893       893               
=============================================
+ Hits          4698      4700        +2     
  Misses         459       459               
  Partials       176       176               
Impacted Files Coverage Δ
sanic/http/tls/creators.py 95.614% <ø> (ø)
sanic/mixins/startup.py 91.898% <ø> (ø)
sanic/server/socket.py 100.000% <ø> (ø)
sanic/types/shared_ctx.py 100.000% <ø> (ø)
sanic/worker/reloader.py 97.058% <100.000%> (+0.089%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ahopkins ahopkins merged commit 65d7447 into main Oct 31, 2022
@ahopkins ahopkins deleted the issue2566 branch October 31, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto reloader consumes full CPU core
2 participants