Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate File When Requested #2526

Merged
merged 23 commits into from Aug 18, 2022
Merged

Validate File When Requested #2526

merged 23 commits into from Aug 18, 2022

Conversation

ChihweiLHBird
Copy link
Member

Return status code of 304 when the conditions are satisfied.

@ChihweiLHBird ChihweiLHBird requested a review from a team as a code owner August 11, 2022 07:00
@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #2526 (4e269ef) into main (09089b1) will increase coverage by 0.024%.
The diff coverage is 95.833%.

@@              Coverage Diff              @@
##              main     #2526       +/-   ##
=============================================
+ Coverage   87.511%   87.535%   +0.024%     
=============================================
  Files           69        69               
  Lines         5581      5600       +19     
  Branches       969       973        +4     
=============================================
+ Hits          4884      4902       +18     
  Misses         506       506               
- Partials       191       192        +1     
Impacted Files Coverage Δ
sanic/response.py 89.622% <95.833%> (+0.503%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sanic/response.py Outdated Show resolved Hide resolved
@ChihweiLHBird ChihweiLHBird linked an issue Aug 12, 2022 that may be closed by this pull request
@ChihweiLHBird
Copy link
Member Author

ChihweiLHBird commented Aug 13, 2022

I am going to improve the test case a little bit.

Update:
Done.

sanic/response.py Outdated Show resolved Hide resolved
sanic/response.py Outdated Show resolved Hide resolved
sanic/response.py Outdated Show resolved Hide resolved
ChihweiLHBird and others added 2 commits August 18, 2022 02:43
Co-authored-by: Adam Hopkins <adam@amhopkins.com>
@ahopkins ahopkins merged commit 753ee99 into main Aug 18, 2022
@ahopkins ahopkins deleted the zhiwei/validate-file branch August 18, 2022 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cache Control: Conditional Request and 304 Response Support
2 participants