Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fall back for Windows even loop fetching #2421

Merged
merged 3 commits into from Apr 17, 2022
Merged

Add fall back for Windows even loop fetching #2421

merged 3 commits into from Apr 17, 2022

Conversation

ahopkins
Copy link
Member

@ahopkins ahopkins commented Apr 3, 2022

No description provided.

@ahopkins ahopkins requested a review from a team as a code owner April 3, 2022 13:43
@codecov
Copy link

codecov bot commented Apr 3, 2022

Codecov Report

Merging #2421 (1cf3626) into main (00218aa) will decrease coverage by 0.066%.
The diff coverage is 42.857%.

@@              Coverage Diff              @@
##              main     #2421       +/-   ##
=============================================
- Coverage   87.202%   87.135%   -0.067%     
=============================================
  Files           60        60               
  Lines         5040      5045        +5     
  Branches       907       908        +1     
=============================================
+ Hits          4395      4396        +1     
- Misses         473       477        +4     
  Partials       172       172               
Impacted Files Coverage Δ
sanic/app.py 88.571% <33.333%> (-0.660%) ⬇️
sanic/__version__.py 100.000% <100.000%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00218aa...1cf3626. Read the comment docs.

Tronic
Tronic previously approved these changes Apr 3, 2022
prryplatypus
prryplatypus previously approved these changes Apr 7, 2022
@prryplatypus prryplatypus linked an issue Apr 8, 2022 that may be closed by this pull request
@sjsadowski
Copy link
Contributor

I don't think this needs to be held out, @ahopkins can you get this in? @prryplatypus reminded me that it's blocking for windows users.

@ahopkins
Copy link
Member Author

I know. I have been planning on releasing it, I just did not want to do it while I was traveling since access to my machine was less than ideal. I should be releasing this version later today.

@ahopkins ahopkins dismissed stale reviews from prryplatypus and Tronic via 1cf3626 April 17, 2022 06:58
@ahopkins ahopkins merged commit cc97287 into main Apr 17, 2022
@ahopkins ahopkins deleted the event-loop branch April 17, 2022 09:25
ChihweiLHBird pushed a commit to ChihweiLHBird/sanic that referenced this pull request Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows: no running event loop as of 22.3.0
4 participants