Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: add msg in task.cancel #2416

Merged
merged 10 commits into from Jun 16, 2022
Merged

style: add msg in task.cancel #2416

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
865f06b
style: add msg in ``task.cancel``
SaidBySolo Mar 25, 2022
7cbf966
style: apply isort
SaidBySolo Mar 25, 2022
8fd36ff
fix: use else statement
SaidBySolo Mar 25, 2022
af27f0a
fix: use tuple
SaidBySolo Mar 25, 2022
42a730a
fix: rollback for test
SaidBySolo Mar 27, 2022
59b355c
fix: rollback like previous change
SaidBySolo Mar 27, 2022
372e194
fix: add ``=``
SaidBySolo Mar 27, 2022
606a095
Merge branch 'main' into gh-2325
SaidBySolo Mar 31, 2022
d759831
Merge branch 'main' into gh-2325
SaidBySolo Apr 17, 2022
539fcbe
Merge branch 'main' into gh-2325
ahopkins Jun 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion sanic/server/protocols/http_protocol.py
View file
Open in desktop
Expand Up @@ -8,6 +8,8 @@
if TYPE_CHECKING: # no cov
from sanic.app import Sanic

import sys

from asyncio import CancelledError
from time import monotonic as current_time

Expand Down Expand Up @@ -169,7 +171,10 @@ def check_timeouts(self):
)
self.loop.call_later(max(0.1, interval), self.check_timeouts)
return
self._task.cancel()
cancel_msg_args = ()
if sys.version_info >= (3, 9):
cancel_msg_args = ("Cancel connection task with a timeout",)
self._task.cancel(*cancel_msg_args)
except Exception:
error_logger.exception("protocol.check_timeouts")

Expand Down