Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to CLI #2401

Merged
merged 11 commits into from Mar 23, 2022
Merged

Changes to CLI #2401

merged 11 commits into from Mar 23, 2022

Conversation

duckduckdroid
Copy link
Contributor

@duckduckdroid duckduckdroid commented Feb 22, 2022

Small changes to help the developer out when their app is not starting

  1. if the cli detects that a function has been passed instead of a Sanic instance it will error out and suggest that the dev uses --factory eg. sanic fake.factory.run

  2. if the cli detects a path has been passed instead of a Sanic instance it will error out and suggest the that the dev uses --simple eg. sanic ./fake/

I welcome all changes and teachings! :)

@duckduckdroid duckduckdroid requested a review from a team as a code owner February 22, 2022 15:36
sanic/cli/app.py Outdated Show resolved Hide resolved
sanic/cli/app.py Outdated Show resolved Hide resolved
sanic/cli/app.py Outdated Show resolved Hide resolved
ahopkins
ahopkins previously approved these changes Mar 22, 2022
@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #2401 (45c1d62) into main (0c9df02) will increase coverage by 0.115%.
The diff coverage is 100.000%.

@@              Coverage Diff              @@
##              main     #2401       +/-   ##
=============================================
+ Coverage   87.110%   87.225%   +0.115%     
=============================================
  Files           60        60               
  Lines         5004      5010        +6     
  Branches       905       904        -1     
=============================================
+ Hits          4359      4370       +11     
+ Misses         472       468        -4     
+ Partials       173       172        -1     
Impacted Files Coverage Δ
sanic/mixins/listeners.py 100.000% <100.000%> (ø)
sanic/mixins/runner.py 95.744% <100.000%> (+0.851%) ⬆️
sanic/server/protocols/http_protocol.py 88.095% <0.000%> (+3.571%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a8e910...45c1d62. Read the comment docs.

@ahopkins ahopkins merged commit 44b108b into sanic-org:main Mar 23, 2022
ChihweiLHBird pushed a commit to ChihweiLHBird/sanic that referenced this pull request Jun 1, 2022
Co-authored-by: Callum Fleming <howzitcal@zohomail.com>
Co-authored-by: Adam Hopkins <adam@amhopkins.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants