New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to CLI #2401
Merged
Merged
Changes to CLI #2401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahopkins
reviewed
Feb 23, 2022
ahopkins
reviewed
Feb 23, 2022
ahopkins
reviewed
Feb 23, 2022
ahopkins
previously approved these changes
Mar 22, 2022
Codecov Report
@@ Coverage Diff @@
## main #2401 +/- ##
=============================================
+ Coverage 87.110% 87.225% +0.115%
=============================================
Files 60 60
Lines 5004 5010 +6
Branches 905 904 -1
=============================================
+ Hits 4359 4370 +11
+ Misses 472 468 -4
+ Partials 173 172 -1
Continue to review full report at Codecov.
|
ahopkins
approved these changes
Mar 22, 2022
ChihweiLHBird
pushed a commit
to ChihweiLHBird/sanic
that referenced
this pull request
Jun 1, 2022
Co-authored-by: Callum Fleming <howzitcal@zohomail.com> Co-authored-by: Adam Hopkins <adam@amhopkins.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small changes to help the developer out when their app is not starting
if the cli detects that a function has been passed instead of a Sanic instance it will error out and suggest that the dev uses
--factory
eg.sanic fake.factory.run
if the cli detects a path has been passed instead of a Sanic instance it will error out and suggest the that the dev uses
--simple
eg.sanic ./fake/
I welcome all changes and teachings! :)