allow multidict version 6 #2396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
ahopkins
approved these changes
Feb 2, 2022
Codecov Report
@@ Coverage Diff @@
## main #2396 +/- ##
=============================================
+ Coverage 87.109% 87.169% +0.059%
=============================================
Files 60 60
Lines 5027 5027
Branches 905 905
=============================================
+ Hits 4379 4382 +3
+ Misses 475 473 -2
+ Partials 173 172 -1
Continue to review full report at Codecov.
|
|
ping @ahopkins |
ChihweiLHBird
pushed a commit
to ChihweiLHBird/sanic
that referenced
this pull request
Jun 1, 2022
Co-authored-by: Adam Hopkins <adam@amhopkins.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only breaking change is the dropped support for Python 3.6, which sanic doesn't support anyway: https://github.com/aio-libs/multidict/releases/tag/v6.0.0