Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade warnings to backwater debug messages #2382

Merged
merged 3 commits into from Jan 19, 2022
Merged

Conversation

ahopkins
Copy link
Member

Most people do not care about these warnings. Let's only show them as debug messages with increased verbosity.

@ahopkins ahopkins requested a review from a team as a code owner January 18, 2022 09:44
@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #2382 (391eebc) into main (bb517dd) will decrease coverage by 0.032%.
The diff coverage is 80.000%.

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #2382       +/-   ##
=============================================
- Coverage   87.122%   87.090%   -0.033%     
=============================================
  Files           60        60               
  Lines         5001      5004        +3     
  Branches       904       905        +1     
=============================================
+ Hits          4357      4358        +1     
+ Misses         473       472        -1     
- Partials       171       174        +3     
Impacted Files Coverage Δ
sanic/asgi.py 88.333% <80.000%> (-1.411%) ⬇️
sanic/server/protocols/http_protocol.py 84.523% <0.000%> (-3.572%) ⬇️
sanic/app.py 89.494% <0.000%> (+0.583%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb517dd...391eebc. Read the comment docs.

ashleysommer
ashleysommer previously approved these changes Jan 18, 2022
@Tronic
Copy link
Member

Tronic commented Jan 18, 2022

Full diff coverage, perhaps?

@ahopkins
Copy link
Member Author

Full diff coverage, perhaps?

Fine. 😠 I won't be so lazy...

@ahopkins ahopkins merged commit ac388d6 into main Jan 19, 2022
@ahopkins ahopkins deleted the remove-warnings branch January 19, 2022 12:26
ChihweiLHBird pushed a commit to ChihweiLHBird/sanic that referenced this pull request Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants