New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tasks): newly assigned None
in registry
#2381
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2381 +/- ##
=============================================
+ Coverage 87.090% 87.107% +0.017%
=============================================
Files 60 60
Lines 5004 5003 -1
Branches 905 905
=============================================
Hits 4358 4358
Misses 472 472
+ Partials 174 173 -1
Continue to review full report at Codecov.
|
None
in registry
Can you add a unit test? |
All tests passed! I'm not sure if the test I wrote is correct. |
How to reproduce?
sanic/sanic/app.py
Lines 1273 to 1274 in b8d9914
If a name is not registered during create_task, the following name is obtained as
Task-1
, so the error that occurred because it is newly assigned has been resolved.