Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove error_logger on websockets #2373

Merged
merged 4 commits into from Mar 23, 2022
Merged

remove error_logger on websockets #2373

merged 4 commits into from Mar 23, 2022

Conversation

jonra1993
Copy link
Contributor

Fixes #2371

It also customized pyproject.toml for easier setup with poetry. I think the email is not correct.

@ahopkins
Copy link
Member

We do not use poerty and want to have code for specific tools only used by some contributors in the code base. Can you remove the changes to pyproject.toml?

Copy link
Member

@ahopkins ahopkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than the poetry specific changes. Also, it's not helpful to have meta in two places.

@jonra1993
Copy link
Contributor Author

jonra1993 commented Jan 14, 2022

Looks good other than the poetry specific changes. Also, it's not helpful to have meta in two places.

Sure no problem I am going to remove poetry changes

@codecov
Copy link

codecov bot commented Jan 15, 2022

Codecov Report

Merging #2373 (16d1bc7) into main (32962d1) will not change coverage.
The diff coverage is 100.000%.

@@            Coverage Diff            @@
##              main     #2373   +/-   ##
=========================================
  Coverage   87.109%   87.109%           
=========================================
  Files           60        60           
  Lines         5027      5027           
  Branches       905       905           
=========================================
  Hits          4379      4379           
  Misses         475       475           
  Partials       173       173           
Impacted Files Coverage Δ
sanic/server/protocols/websocket_protocol.py 70.312% <100.000%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32962d1...16d1bc7. Read the comment docs.

@ahopkins ahopkins merged commit 361c242 into sanic-org:main Mar 23, 2022
ChihweiLHBird pushed a commit to ChihweiLHBird/sanic that referenced this pull request Jun 1, 2022
Co-authored-by: Adam Hopkins <adam@amhopkins.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Websocket logger uses sanic.log.error_logger
2 participants