New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add named tasks #2304
Merged
Merged
Add named tasks #2304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Climate has analyzed commit ebc4a7a and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (86% is the threshold). This pull request will bring the total coverage in the repository to 86.8% (0.0% change). View more on Code Climate. |
prryplatypus
approved these changes
Dec 20, 2021
This pull request has been mentioned on Sanic Community Discussion. There might be relevant details there: |
ChihweiLHBird
pushed a commit
to ChihweiLHBird/sanic
that referenced
this pull request
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fairly simple PR that adds something that adds naming
asyncio.Task
. If you create a named task, it will also allow you to add it to a registry (if requested) for simple callback after.This PR adds the following new attributes to application instances:
app.get_task
app.cancel_task
app.purge_tasks
app.shutdown_tasks
app.tasks
In addition, on
app.add_task
it has a return value of the new task IF you are inside of the running loop.TODO:
app.cancel_task("foo")
add_task
when created inside application (and not in global scope where it is added to delayed execution)Closes #2301
Closes #2267