Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dispatch http.lifecyle.response from exception handler #2299

Merged
merged 4 commits into from Nov 19, 2021
Merged

Dispatch http.lifecyle.response from exception handler #2299

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a60b0e7
Resolves sanic-org /sanic:2297
whos4n3 Nov 5, 2021
b5439d2
Merge branch 'main' into patch-1
ahopkins Nov 18, 2021
5f53a6e
Remove extra space
ahopkins Nov 18, 2021
06a062e
Merge branch 'main' into patch-1
ahopkins Nov 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions sanic/app.py
View file
Open in desktop
Expand Up @@ -775,6 +775,14 @@ async def handle_exception(
if request.stream:
response = request.stream.response
if isinstance(response, BaseHTTPResponse):
await self.dispatch(
"http.lifecycle.response",
inline=True,
context={
"request": request,
"response": response,
},
)
await response.send(end_stream=True)
else:
raise ServerError(
Expand Down
1 change: 0 additions & 1 deletion sanic/errorpages.py
View file
Open in desktop
Expand Up @@ -383,7 +383,6 @@ def exception_response(
"""
content_type = None

print("exception_response", fallback)
if not renderer:
# Make sure we have something set
renderer = base
Expand Down