Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ipv6 display in startup info log #2285

Merged
merged 5 commits into from Oct 24, 2021
Merged

fix ipv6 display in startup info log #2285

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
57a0620
fix ipv6 display in startup info log
sjsadowski Oct 24, 2021
01676e7
refactored to oneliner by request
sjsadowski Oct 24, 2021
3feb06a
Added test for passing ipv4 host
sjsadowski Oct 24, 2021
b764156
Added test for passing ipv6 any host
sjsadowski Oct 24, 2021
60b7086
Added test for passing ipv6 loopback host
sjsadowski Oct 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion sanic/app.py
View file
Open in desktop
Expand Up @@ -1337,7 +1337,9 @@ def _helper(
if unix:
logger.info(f"Goin' Fast @ {unix} {proto}://...")
else:
logger.info(f"Goin' Fast @ {proto}://{host}:{port}")
# colon(:) is legal for a host only in an ipv6 address
display_host = f"[{host}]" if ":" in host else host
logger.info(f"Goin' Fast @ {proto}://{display_host}:{port}")

debug_mode = "enabled" if self.debug else "disabled"
reload_mode = "enabled" if auto_reload else "disabled"
Expand Down