Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vhost support using multiple TLS certificates #2270

Merged
merged 40 commits into from Oct 28, 2021
Merged

Vhost support using multiple TLS certificates #2270

merged 40 commits into from Oct 28, 2021

Commits on Oct 15, 2021

  1. Initial support for using multiple SSL certificates.

    @Tronic
    Tronic committed Oct 15, 2021
    Copy the full SHA
    379b1a2 View commit details
    Browse the repository at this point in the history

  2. Also list IP address subjectAltNames on log.

    @Tronic
    Tronic committed Oct 15, 2021
    Copy the full SHA
    978a905 View commit details
    Browse the repository at this point in the history

  3. Use Python 3.7+ way of specifying TLSv1.2 as the minimum version. Lin… 

    …ter fixes.
    @Tronic
    Tronic committed Oct 15, 2021
    Copy the full SHA
    e769733 View commit details
    Browse the repository at this point in the history

  4. isort

    @Tronic
    Tronic committed Oct 15, 2021
    Copy the full SHA
    13fbaa5 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2021

  1. Cleanup, store server name for later use. Add RSA ciphers. Log reject… 

    …ed SNIs.
    @Tronic
    Tronic committed Oct 16, 2021
    Copy the full SHA
    794c350 View commit details
    Browse the repository at this point in the history

  2. Cleanup, linter.

    @Tronic
    Tronic committed Oct 16, 2021
    Copy the full SHA
    afb9bd4 View commit details
    Browse the repository at this point in the history

  3. Alter the order of initial log messages and handling. In particular, … 

    …enable debug mode early so that debug messages during init can be shown.
    @Tronic
    Tronic committed Oct 16, 2021
    Copy the full SHA
    643fd54 View commit details
    Browse the repository at this point in the history

  4. Store server name (SNI) to conn_info.

    @Tronic
    Tronic committed Oct 16, 2021
    Copy the full SHA
    497d58d View commit details
    Browse the repository at this point in the history

  5. Update test with new error message.

    @Tronic
    Tronic committed Oct 16, 2021
    Copy the full SHA
    69a7e91 View commit details
    Browse the repository at this point in the history

  6. Refactor for readability.

    @Tronic
    Tronic committed Oct 16, 2021
    Copy the full SHA
    1bd8c23 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2021

  1. Cleanup

    @Tronic
    Tronic committed Oct 17, 2021
    Copy the full SHA
    098b167 View commit details
    Browse the repository at this point in the history

  2. Replace old expired test cert with new ones and a script for regenera… 

    …ting them as needed.
    @Tronic
    Tronic committed Oct 17, 2021
    Copy the full SHA
    b82c3f0 View commit details
    Browse the repository at this point in the history

  3. Refactor TLS tests to a separate file.

    @Tronic
    Tronic committed Oct 17, 2021
    Copy the full SHA
    01299bf View commit details
    Browse the repository at this point in the history

  4. Add cryptography to dev deps for rebuilding TLS certs.

    @Tronic
    Tronic committed Oct 17, 2021
    Copy the full SHA
    b5bde3c View commit details
    Browse the repository at this point in the history

  5. Minor adjustment to messages.

    @Tronic
    Tronic committed Oct 17, 2021
    Copy the full SHA
    1760755 View commit details
    Browse the repository at this point in the history

  6. Tests added for new TLS code.

    @Tronic
    Tronic committed Oct 17, 2021
    Copy the full SHA
    f59006a View commit details
    Browse the repository at this point in the history

  7. Find the correct log row before testing for message. The order was di… 

    …fferent on CI.
    @Tronic
    Tronic committed Oct 17, 2021
    Copy the full SHA
    da22609 View commit details
    Browse the repository at this point in the history

  8. More log message order fixup. The tests do not account for the logo b… 

    …eing printed first.
    @Tronic
    Tronic committed Oct 17, 2021
    Copy the full SHA
    8c9eb42 View commit details
    Browse the repository at this point in the history

  9. Another attempt at log message indexing fixup.

    @Tronic
    Tronic committed Oct 17, 2021
    Copy the full SHA
    1c3353c View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2021

  1. Major TLS refactoring. 

    CertSelector now allows dicts and SSLContext within its list.
Server names are stored even when no list is used.
SSLContext.sanic now contains a dict with any setting passed and information extracted from cert.
That information is available on request.conn_info.cert.
Type annotations added.
More tests incl. a handler for faking hostname in tests.
    @Tronic
    Tronic committed Oct 19, 2021
    Copy the full SHA
    8244f3f View commit details
    Browse the repository at this point in the history

  2. Remove a problematic logger test that apparently was not adding any c… 

    …overage or value to anything.
    @Tronic
    Tronic committed Oct 19, 2021
    Copy the full SHA
    e3861ab View commit details
    Browse the repository at this point in the history

  3. Revert accidental commit of uvloop disable.

    @Tronic
    Tronic committed Oct 19, 2021
    Copy the full SHA
    320361c View commit details
    Browse the repository at this point in the history

  4. Typing fixes / refactoring.

    @Tronic
    Tronic committed Oct 19, 2021
    Copy the full SHA
    2a8d7e0 View commit details
    Browse the repository at this point in the history

  5. Additional test for cert selection. Certs recreated without DNS:local… 

    …host on sanic.example cert.
    @Tronic
    Tronic committed Oct 19, 2021
    Copy the full SHA
    32f2f03 View commit details
    Browse the repository at this point in the history

  6. Add tests for single certificate path shorthand and SNI information.

    @Tronic
    Tronic committed Oct 19, 2021
    Copy the full SHA
    14f4e8b View commit details
    Browse the repository at this point in the history

  7. Move TLS dict processing to CertSimple, make the names field optional… 

    … and use names from the cert if absent.
    @Tronic
    Tronic committed Oct 19, 2021
    Copy the full SHA
    62a1c36 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2021

  1. Sanic CLI options --tls and --tls-strict-host to use the new features.

    @Tronic
    Tronic committed Oct 24, 2021
    Copy the full SHA
    f790e27 View commit details
    Browse the repository at this point in the history

  2. SSL argument typing updated

    @Tronic
    Tronic committed Oct 24, 2021
    Copy the full SHA
    76f9573 View commit details
    Browse the repository at this point in the history

  3. Use ValueError for internal message passing to avoid CertificateError… 

    …'s odd message formatting.
    @Tronic
    Tronic committed Oct 24, 2021
    Copy the full SHA
    60cfd72 View commit details
    Browse the repository at this point in the history

  4. Linter

    @Tronic
    Tronic committed Oct 24, 2021
    Copy the full SHA
    5d25739 View commit details
    Browse the repository at this point in the history

  5. Test CLI TLS options.

    @Tronic
    Tronic committed Oct 24, 2021
    Copy the full SHA
    888aee4 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into tls-vhosts

    @Tronic
    Tronic committed Oct 24, 2021
    Copy the full SHA
    72f6b9d View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into tls-vhosts

    @Tronic
    Tronic committed Oct 24, 2021
    Copy the full SHA
    eeea1f0 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into tls-vhosts

    @Tronic
    Tronic committed Oct 24, 2021
    Copy the full SHA
    4b28ebb View commit details
    Browse the repository at this point in the history

  9. Maybe the right codeclimate option now...

    @Tronic
    Tronic committed Oct 24, 2021
    Copy the full SHA
    6f7fcfd View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2021

  1. Merge branch 'main' into tls-vhosts

    @ahopkins
    ahopkins committed Oct 27, 2021
    Copy the full SHA
    b7c20b2 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into tls-vhosts

    @Tronic
    Tronic committed Oct 27, 2021
    Copy the full SHA
    ee00e42 View commit details
    Browse the repository at this point in the history

  3. Improved TLS argument help, removed support for combining --cert/--ke… 

    …y with --tls.
    @Tronic
    Tronic committed Oct 27, 2021
    Copy the full SHA
    3991b60 View commit details
    Browse the repository at this point in the history

  4. Removed support for strict checking without any certs, black forced f… 

    …scked up formatting.
    @Tronic
    Tronic committed Oct 27, 2021
    Copy the full SHA
    66a07c1 View commit details
    Browse the repository at this point in the history

  5. Update CLI tests for stricter TLS options.

    @Tronic
    Tronic committed Oct 27, 2021
    Copy the full SHA
    bb793fa View commit details
    Browse the repository at this point in the history