Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uvloop to 0.14.0 #2024

Merged
merged 2 commits into from Feb 15, 2021
Merged

Fix uvloop to 0.14.0 #2024

merged 2 commits into from Feb 15, 2021

Conversation

ahopkins
Copy link
Member

@ahopkins ahopkins commented Feb 15, 2021

uvloop is dropping python 3.6 support. I think we should also, but I am not quite ready to do that in v21.3. In the mean time, let's fix uvloop to 0.14. Also making a PR for LTS.

@codecov
Copy link

codecov bot commented Feb 15, 2021

Codecov Report

Merging #2024 (c942a5c) into master (ffca01f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2024   +/-   ##
=======================================
  Coverage   91.45%   91.45%           
=======================================
  Files          28       28           
  Lines        3171     3171           
  Branches      571      571           
=======================================
  Hits         2900     2900           
  Misses        192      192           
  Partials       79       79           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffca01f...c942a5c. Read the comment docs.

This was referenced Feb 15, 2021
@ashleysommer
Copy link
Member

ashleysommer commented Feb 15, 2021

Why fix it to exactly 0.14? That could be an upper limit:
uvloop>=0.5.3,<=0.14.0
That might be more compatible for users who require uvloop pinned to other versions.

@ahopkins
Copy link
Member Author

Fair enough. That is what I did for the two LTS branches: #2025, #2026

@ahopkins ahopkins merged commit 4c29846 into master Feb 15, 2021
@ahopkins ahopkins deleted the fix-uvloop-version branch February 15, 2021 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants