docs: Fix doc build

[chenjr0719]

This PR aims to fix the doc build filed on readthedocs.

close #1832

[chenjr0719]

BTW, the CI failed because of the new release of pytest-asyncio. Do you think we need to use the previous version instead? The pytest-asyncio is defined in tox.ini:
https://github.com/huge-success/sanic/blob/ae40f960ff0aa1c0ce24c50411faae6f16790acf/tox.ini#L12

[Tronic]

BTW, the CI failed because of the new release of pytest-asyncio. Do you think we need to use the previous version instead?

I wonder what else should be upgraded for the new version to work. In any case, if pinning an older version in tox.ini gets the job done, it's OK.

Since this is the only PR hit by the test problem so far, I suggest that you do the change on this same PR despite it being a separate problem (because otherwise this bogus test failure will prevent merging).

Thanks for keeping the plumbing working! :)

[yunstanford]

Do we need pytest-asyncio ?

[chenjr0719]

Do we need pytest-asyncio ?

We have a lot of tests are implemented in async so I think yes we need it. For example:
https://github.com/huge-success/sanic/blob/ae40f960ff0aa1c0ce24c50411faae6f16790acf/tests/test_asgi.py#L245-L258

And, this issue is caused by the unmeet required version of pytest. The pytest-asyncio is required pytest>=5.4.0 but we pin it to 5.2.1. However, if using pytest>=5.4.0, then the pytest-sugar will cause another error. 🤔 They also discuss about this dependency issue at Teemu/pytest-sugar#187.

So, I would suggest that we can bump to pytest>=5.4.0 and remove pytest-sugar to fix current CI failed first. And if we really need pytest-sugar, we can add it back when they fix the dependency issue. What do you think?

[yunstanford]

pytest-sanic will handle those async tests.

[codecov]

Codecov Report

Merging #1833 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1833   +/-   ##
=======================================
  Coverage   92.18%   92.18%           
=======================================
  Files          23       23           
  Lines        2315     2315           
  Branches      425      425           
=======================================
  Hits         2134     2134           
  Misses        141      141           
  Partials       40       40           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae40f96...9f18a3f. Read the comment docs.

[chenjr0719]

OK, then I think the pytest-asyncio is not necessary anymore. After removing it, the CI now working. Thanks, @yunstanford. 😃

[yunstanford]

Thanks for the fix!