New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove error_logger on websockets #2373
Conversation
We do not use poerty and want to have code for specific tools only used by some contributors in the code base. Can you remove the changes to pyproject.toml? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good other than the poetry specific changes. Also, it's not helpful to have meta in two places.
Sure no problem I am going to remove poetry changes |
Codecov Report
@@ Coverage Diff @@
## main #2373 +/- ##
=========================================
Coverage 87.109% 87.109%
=========================================
Files 60 60
Lines 5027 5027
Branches 905 905
=========================================
Hits 4379 4379
Misses 475 475
Partials 173 173
Continue to review full report at Codecov.
|
Co-authored-by: Adam Hopkins <adam@amhopkins.com>
Fixes #2371
It also customized pyproject.toml for easier setup with poetry. I think the email is not correct.