Fix typehints in route shorthand methods (#2317)

* Fix typehints in route shorthand methods Change typehint of the version variable in RouteMixin to allow int string and float types values Resolves #2314 * fix lint error in version variable
sanic-org · Nov 19, 2021 · 9c576c7 · 9c576c7
1 parent 523db19
commit 9c576c7
Showing 1 changed file with 10 additions and 10 deletions.
diff --git a/sanic/mixins/routes.py b/sanic/mixins/routes.py
@@ -191,7 +191,7 @@ def add_route(
         methods: Iterable[str] = frozenset({"GET"}),
         host: Optional[str] = None,
         strict_slashes: Optional[bool] = None,
-        version: Optional[int] = None,
+        version: Optional[Union[int, str, float]] = None,
         name: Optional[str] = None,
         stream: bool = False,
         version_prefix: str = "/v",
@@ -256,7 +256,7 @@ def get(
         uri: str,
         host: Optional[str] = None,
         strict_slashes: Optional[bool] = None,
-        version: Optional[int] = None,
+        version: Optional[Union[int, str, float]] = None,
         name: Optional[str] = None,
         ignore_body: bool = True,
         version_prefix: str = "/v",
@@ -293,7 +293,7 @@ def post(
         host: Optional[str] = None,
         strict_slashes: Optional[bool] = None,
         stream: bool = False,
-        version: Optional[int] = None,
+        version: Optional[Union[int, str, float]] = None,
         name: Optional[str] = None,
         version_prefix: str = "/v",
         error_format: Optional[str] = None,
@@ -329,7 +329,7 @@ def put(
         host: Optional[str] = None,
         strict_slashes: Optional[bool] = None,
         stream: bool = False,
-        version: Optional[int] = None,
+        version: Optional[Union[int, str, float]] = None,
         name: Optional[str] = None,
         version_prefix: str = "/v",
         error_format: Optional[str] = None,
@@ -364,7 +364,7 @@ def head(
         uri: str,
         host: Optional[str] = None,
         strict_slashes: Optional[bool] = None,
-        version: Optional[int] = None,
+        version: Optional[Union[int, str, float]] = None,
         name: Optional[str] = None,
         ignore_body: bool = True,
         version_prefix: str = "/v",
@@ -408,7 +408,7 @@ def options(
         uri: str,
         host: Optional[str] = None,
         strict_slashes: Optional[bool] = None,
-        version: Optional[int] = None,
+        version: Optional[Union[int, str, float]] = None,
         name: Optional[str] = None,
         ignore_body: bool = True,
         version_prefix: str = "/v",
@@ -453,7 +453,7 @@ def patch(
         host: Optional[str] = None,
         strict_slashes: Optional[bool] = None,
         stream=False,
-        version: Optional[int] = None,
+        version: Optional[Union[int, str, float]] = None,
         name: Optional[str] = None,
         version_prefix: str = "/v",
         error_format: Optional[str] = None,
@@ -498,7 +498,7 @@ def delete(
         uri: str,
         host: Optional[str] = None,
         strict_slashes: Optional[bool] = None,
-        version: Optional[int] = None,
+        version: Optional[Union[int, str, float]] = None,
         name: Optional[str] = None,
         ignore_body: bool = True,
         version_prefix: str = "/v",
@@ -535,7 +535,7 @@ def websocket(
         host: Optional[str] = None,
         strict_slashes: Optional[bool] = None,
         subprotocols: Optional[List[str]] = None,
-        version: Optional[int] = None,
+        version: Optional[Union[int, str, float]] = None,
         name: Optional[str] = None,
         apply: bool = True,
         version_prefix: str = "/v",
@@ -576,7 +576,7 @@ def add_websocket_route(
         host: Optional[str] = None,
         strict_slashes: Optional[bool] = None,
         subprotocols=None,
-        version: Optional[int] = None,
+        version: Optional[Union[int, str, float]] = None,
         name: Optional[str] = None,
         version_prefix: str = "/v",
         error_format: Optional[str] = None,